Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use list config for FunctionOnlyReturningConstant>excludedFunctions #5120

Merged
merged 2 commits into from Aug 3, 2022

Conversation

BraisGabin
Copy link
Collaborator

No description provided.

@BraisGabin BraisGabin added this to the 1.22.0 milestone Jul 23, 2022
@github-actions github-actions bot added the rules label Jul 23, 2022
@BraisGabin BraisGabin force-pushed the use-config-list-FunctionOnlyReturningConstant branch from 9206311 to f997f62 Compare July 23, 2022 14:08
@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #5120 (f377c01) into main (3bc81d2) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##               main    #5120      +/-   ##
============================================
- Coverage     84.97%   84.96%   -0.01%     
  Complexity     3638     3638              
============================================
  Files           502      502              
  Lines         11971    11972       +1     
  Branches       2258     2259       +1     
============================================
  Hits          10172    10172              
  Misses          689      689              
- Partials       1110     1111       +1     
Impacted Files Coverage Δ
...etekt/rules/style/FunctionOnlyReturningConstant.kt 93.75% <33.33%> (-2.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@BraisGabin BraisGabin force-pushed the use-config-list-FunctionOnlyReturningConstant branch from f997f62 to 21ea124 Compare July 23, 2022 14:20
@marschwar marschwar added the notable changes Marker for notable changes in the changelog label Jul 29, 2022
val code = "fun f() = 1"
val config = TestConfig(mapOf(EXCLUDED_FUNCTIONS to listOf("f")))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be something utilizing wildcards?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a new test for that.

@BraisGabin BraisGabin force-pushed the use-config-list-FunctionOnlyReturningConstant branch from 21ea124 to c8830e0 Compare August 3, 2022 14:36
…/rules/style/FunctionOnlyReturningConstant.kt

Co-authored-by: marschwar <marschwar@users.noreply.github.com>
@BraisGabin BraisGabin enabled auto-merge (squash) August 3, 2022 14:36
@BraisGabin BraisGabin merged commit f37d44b into main Aug 3, 2022
20 of 21 checks passed
@BraisGabin BraisGabin deleted the use-config-list-FunctionOnlyReturningConstant branch August 3, 2022 15:04
@cortinico cortinico removed the notable changes Marker for notable changes in the changelog label Sep 19, 2022
@cortinico
Copy link
Member

I won't mention this in the notable changes as the list is getting quite long. Should I add a paragraph in the migration section of the changelog?

@cortinico
Copy link
Member

I won't mention this in the notable changes as the list is getting quite long. Should I add a paragraph in the migration section of the changelog?

Follow up for @arturbosch here: it seems we need this info in the changelog then 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants