Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ExitOutsideMain if contextBinding is empty #5127

Merged
merged 1 commit into from Jul 24, 2022
Merged

Conversation

BraisGabin
Copy link
Collaborator

We weren't checking against the correct context.

@BraisGabin BraisGabin added this to the 1.22.0 milestone Jul 24, 2022
@github-actions github-actions bot added the rules label Jul 24, 2022
@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #5127 (573d4d2) into main (e4a2bf5) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main    #5127   +/-   ##
=========================================
  Coverage     84.91%   84.91%           
+ Complexity     3614     3613    -1     
=========================================
  Files           502      502           
  Lines         11887    11887           
  Branches       2237     2237           
=========================================
  Hits          10094    10094           
  Misses          690      690           
  Partials       1103     1103           
Impacted Files Coverage Δ
...ab/arturbosch/detekt/rules/bugs/ExitOutsideMain.kt 71.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4a2bf5...573d4d2. Read the comment docs.

3flex
3flex approved these changes Jul 24, 2022
@BraisGabin BraisGabin merged commit 569697c into main Jul 24, 2022
20 of 21 checks passed
@BraisGabin BraisGabin deleted the ExitOutsideMain branch July 24, 2022 23:53
VitalyVPinchuk pushed a commit to VitalyVPinchuk/detekt that referenced this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants