Skip to content

remove SimpleGlob in favor of String.simplePatternToRegex() - #5144

Merged
marschwar merged 1 commit into
detekt:mainfrom
marschwar:chore/remove-simple-glob
Jul 29, 2022
Merged

marschwar merged 1 commit into
detekt:mainfrom
marschwar:chore/remove-simple-glob

Conversation

@marschwar

Copy link
Copy Markdown
Contributor

This removes the SimpleGlob type which does essentially the same
as the String.simplePatternToRegex() extension function.

'?' matches any one character

I changed the implementation to match the documentation.

@marschwar marschwar added housekeeping Marker for housekeeping tasks and refactorings and removed rules labels Jul 28, 2022

@BraisGabin BraisGabin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@marschwar
marschwar merged commit 0d6f790 into detekt:main Jul 29, 2022
@marschwar
marschwar deleted the chore/remove-simple-glob branch July 29, 2022 11:11
@cortinico cortinico added this to the 1.22.0 milestone Jul 30, 2022

This branch was successfully deployed

1 active deployment
Preview — 958709b8 Deployed Jul 28, 2022 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants