Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle slf4j-nop in detekt-formatting JAR #5153

Merged
merged 2 commits into from Aug 1, 2022
Merged

Conversation

3flex
Copy link
Collaborator

@3flex 3flex commented Jul 31, 2022

Fixes #4811

@github-actions github-actions bot added the build label Jul 31, 2022
@3flex 3flex changed the title Add CLI runtime dependency on slf4j-nop Move slf4j-nop runtime dependency to CLI Jul 31, 2022
detekt-cli/build.gradle.kts Outdated Show resolved Hide resolved
@3flex 3flex changed the title Move slf4j-nop runtime dependency to CLI Bundle slf4j-nop in detekt-formatting JAR Jul 31, 2022
Hides this warning:
    SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
    SLF4J: Defaulting to no-operation (NOP) logger implementation
    SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
@schalkms schalkms added this to the 1.22.0 milestone Aug 1, 2022
@schalkms schalkms merged commit e4bb31b into detekt:main Aug 1, 2022
19 checks passed
@3flex 3flex deleted the 4811-fix branch August 1, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SLF4J Warning after updating to 1.20
4 participants