Limit Kotlin version warning suppression scope in build#5156
Merged
Conversation
61b6406 to
d69bfe0
Compare
cortinico
approved these changes
Jul 31, 2022
schalkms
approved these changes
Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Gradle plugin requires a lower API version to maintain compatibility with older Gradle versions.
detekt itself doesn't need to limit itself to older API versions as it uses its own Kotlin dependency to execute, which is different from the version Gradle embeds. This PR updates the build configuration to align - now other modules can use the current Kotlin API and don't need to suppress version warnings. This is now applied only to the Gradle plugin.