Mark MultiRule as deprecated#5161
Conversation
| fun isCorrectable(rule: BaseRule): Boolean = when (rule) { | ||
| is Rule -> rule.autoCorrect | ||
| is MultiRule -> rule.rules.any { it.autoCorrect } | ||
| is io.gitlab.arturbosch.detekt.api.MultiRule -> rule.rules.any { it.autoCorrect } |
There was a problem hiding this comment.
Is this intended that we want to use the full qualified name for MultiRule?
There was a problem hiding this comment.
Is there any other way (besides suppressing deprecation warning for the entire file) to avoid the build to fail because of a deprecated import?
There was a problem hiding this comment.
There is not as far as I know. It would be really good to know if there is any other way.
|
You have a couple of references inside |
Codecov Report
@@ Coverage Diff @@
## main #5161 +/- ##
===========================================
+ Coverage 0 84.95% +84.95%
- Complexity 0 3638 +3638
===========================================
Files 0 502 +502
Lines 0 11992 +11992
Branches 0 2260 +2260
===========================================
+ Hits 0 10188 +10188
- Misses 0 691 +691
- Partials 0 1113 +1113
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This is the first step in removing
MultiRule. It closes #4240.I will create a checklist (or separate issues) for all remaining steps.
Note: I changed the usages to fully qualified as the build was failing with deprecation warnings in the imports and I did not want to suppress deprecation warnings for the entire file.