Enable Predictive Test Selection for local builds#5170
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5170 +/- ##
=========================================
Coverage 84.98% 84.98%
Complexity 3634 3634
=========================================
Files 502 502
Lines 11966 11966
Branches 2255 2255
=========================================
Hits 10169 10169
Misses 689 689
Partials 1108 1108 Help us with your feedback. Take ten seconds to tell us how you rate us. |
schalkms
approved these changes
Aug 2, 2022
Member
Author
|
Me too! This report can be used to monitor: https://ge.detekt.dev/scans/test-selection I haven't delved into it but in theory that will surface any issues... Though the ML model should take those issues and incorrect misses and improve over time. |
Member
|
Yeah, let’s see how it works out. Later on, we can still enable PTS for PRs too. |
cortinico
approved these changes
Aug 2, 2022
BraisGabin
approved these changes
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4992
Example results: https://ge.detekt.dev/s/zw2mley3hbwz6/tests/overview. The build was run simply with
./gradlew teston the main branch.This enables PTS only for local builds. Gradle recommends enabling PTS for local builds and PRs, however it's simpler and lower risk to leave disabled on CI entirely. Maybe we can enable on PRs too once we have some experience with it.
This doesn't apply to detekt-gradle-plugin, which is unfortunate because it's the slowest test suite, but currently included builds are not supported so this is a technical limitation. Config can be updated in future if this changes.
This is an
@Internalproperty so the different value in CI & non-CI builds doesn't impact remote build cache hits.