Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to ignore overloaded methods for the complex interface rule (#5165) #5173

Merged
merged 3 commits into from Aug 5, 2022
Merged

Allow to ignore overloaded methods for the complex interface rule (#5165) #5173

merged 3 commits into from Aug 5, 2022

Conversation

pt2121
Copy link
Contributor

@pt2121 pt2121 commented Aug 3, 2022

Closes #5165

ComplexInterface: do not count method overloads

@github-actions github-actions bot added the rules label Aug 3, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #5173 (66c142d) into main (d42e6f0) will decrease coverage by 0.00%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##               main    #5173      +/-   ##
============================================
- Coverage     84.97%   84.97%   -0.01%     
  Complexity     3638     3638              
============================================
  Files           502      502              
  Lines         11971    11983      +12     
  Branches       2258     2261       +3     
============================================
+ Hits          10172    10182      +10     
  Misses          689      689              
- Partials       1110     1112       +2     
Impacted Files Coverage Δ
...rbosch/detekt/rules/complexity/ComplexInterface.kt 89.13% <85.71%> (+0.55%) ⬆️
...etekt/rules/style/FunctionOnlyReturningConstant.kt 93.75% <0.00%> (-2.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this nice first PR! I like it.

Below, you find two comments regarding naming and style.
Then, I'd say LGTM.

@schalkms schalkms merged commit 829fae2 into detekt:main Aug 5, 2022
21 checks passed
@pt2121 pt2121 deleted the pt/5165-overloaded branch August 6, 2022 00:30
@pt2121
Copy link
Contributor Author

pt2121 commented Aug 6, 2022

Thanks for reviewing and merging it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ComplexInterface: do not count method overloads
2 participants