Allow to ignore overloaded methods for the complex interface rule (#5165)#5173
Merged
schalkms merged 3 commits intodetekt:mainfrom Aug 5, 2022
pt2121:pt/5165-overloaded
Merged
Allow to ignore overloaded methods for the complex interface rule (#5165)#5173schalkms merged 3 commits intodetekt:mainfrom pt2121:pt/5165-overloaded
schalkms merged 3 commits intodetekt:mainfrom
pt2121:pt/5165-overloaded
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5173 +/- ##
============================================
- Coverage 84.97% 84.97% -0.01%
Complexity 3638 3638
============================================
Files 502 502
Lines 11971 11983 +12
Branches 2258 2261 +3
============================================
+ Hits 10172 10182 +10
Misses 689 689
- Partials 1110 1112 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
schalkms
reviewed
Aug 3, 2022
Member
schalkms
left a comment
schalkms
left a comment
There was a problem hiding this comment.
Thank you for this nice first PR! I like it.
Below, you find two comments regarding naming and style.
Then, I'd say LGTM.
schalkms
approved these changes
Aug 4, 2022
Contributor
Author
|
Thanks for reviewing and merging it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5165
ComplexInterface: do not count method overloads