Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ArrayPrimitive rule honor the RequiresTypeResolution annotation #5175

Merged
merged 2 commits into from Aug 4, 2022

Conversation

BraisGabin
Copy link
Collaborator

This PR fixes an issue detected on #5130 related with the rule ArrayPrimitive. Right now it says that it requires type resolution but that's not 100% true. It also detects som issues without it. To honor the annotation this rule will not report those issues without type resolution anymore.

@BraisGabin BraisGabin added this to the 1.22.0 milestone Aug 3, 2022
@github-actions github-actions bot added the rules label Aug 3, 2022
@BraisGabin BraisGabin force-pushed the array-primitive-truly-requires-type-resolution branch from ad311fd to d8e447f Compare August 3, 2022 15:10
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #5175 (497b067) into main (3bc81d2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Current head 497b067 differs from pull request most recent head 3011ede. Consider uploading reports for the commit 3011ede to get more accurate results

@@             Coverage Diff              @@
##               main    #5175      +/-   ##
============================================
- Coverage     84.97%   84.95%   -0.02%     
  Complexity     3638     3638              
============================================
  Files           502      502              
  Lines         11971    11974       +3     
  Branches       2258     2258              
============================================
+ Hits          10172    10173       +1     
  Misses          689      689              
- Partials       1110     1112       +2     
Impacted Files Coverage Δ
...urbosch/detekt/rules/performance/ArrayPrimitive.kt 72.72% <100.00%> (-1.47%) ⬇️
...etekt/rules/style/FunctionOnlyReturningConstant.kt 93.75% <0.00%> (-2.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@schalkms schalkms merged commit eb2fde1 into main Aug 4, 2022
19 checks passed
@schalkms schalkms deleted the array-primitive-truly-requires-type-resolution branch August 4, 2022 10:22
@marschwar marschwar added the notable changes Marker for notable changes in the changelog label Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable changes Marker for notable changes in the changelog rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants