-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove multi rule FileParsingRule #5193
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5193 +/- ##
=========================================
Coverage 84.96% 84.96%
- Complexity 3638 3640 +2
=========================================
Files 502 502
Lines 11985 11982 -3
Branches 2260 2260
=========================================
- Hits 10183 10181 -2
+ Misses 689 688 -1
Partials 1113 1113
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@cortinico seems to be an issue with danger and the GitHub rate limit. Is there something to adapt in the setup?
|
Not really. The problem is with codecov though. For some reason it seems like they post a comment that they edit over and over: This is generating 200+ invocations of the Danger workflow causing the own Github token to go out of quota. The labeller also failed. I'm looking into potentially skipping the workflow if the event trigger was coming from Codecov |
Ouch. 🙈
|
|
||
internal data class KtFileContent(val file: KtFile, val content: Sequence<String>) | ||
|
||
internal fun KtFile.toFileContent() = KtFileContent(this, text.splitToSequence("\n")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ for internal
This is part of #5192.
All rules from the
FileParsingRule
multi rule are now run individually.