Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid constructors with ForbiddenMethodCall #5195

Merged
merged 3 commits into from Aug 8, 2022
Merged

Forbid constructors with ForbiddenMethodCall #5195

merged 3 commits into from Aug 8, 2022

Conversation

BraisGabin
Copy link
Collaborator

Fix #5185


I have no idea what's the real difference between fqNameOrNull and fqNameSafe but with the former all works as expected so 馃し

@schalkms
Copy link
Member

schalkms commented Aug 8, 2022

Interesting question...
Hmm, maybe you might want to ask this in the Kotlin Slack channel.

I have no idea what's the real difference between fqNameOrNull and fqNameSafe but with the former all works as expected so 馃し

@schalkms
Copy link
Member

schalkms commented Aug 8, 2022

Maybe, a hint should be given in the description of this rule that constructors are also supported.

BraisGabin and others added 2 commits August 8, 2022 15:07
鈥/rules/style/ForbiddenMethodCall.kt

Co-authored-by: schalkms <30376729+schalkms@users.noreply.github.com>
@BraisGabin
Copy link
Collaborator Author

Maybe, a hint should be given in the description of this rule that constructors are also supported.

Agree, what do you think about it now?

@schalkms schalkms merged commit 95624c3 into main Aug 8, 2022
21 checks passed
@schalkms schalkms deleted the fix-5185 branch August 8, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forbid constructor calls
3 participants