Skip to content

Remove rule from NamingRules multi rule#5212

Merged
cortinico merged 17 commits into
detekt:mainfrom
gr8-toolkit:remove-naming-multyrule
Sep 10, 2022
Merged

Remove rule from NamingRules multi rule#5212
cortinico merged 17 commits into
detekt:mainfrom
gr8-toolkit:remove-naming-multyrule

Conversation

@VovaStelmashchuk
Copy link
Copy Markdown
Contributor

This is part of #5192

@VovaStelmashchuk
Copy link
Copy Markdown
Contributor Author

@marschwar The merge request ready for review.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 7, 2022

Codecov Report

Merging #5212 (b1f5e19) into main (97fd12b) will decrease coverage by 0.05%.
The diff coverage is 81.81%.

@@             Coverage Diff              @@
##               main    #5212      +/-   ##
============================================
- Coverage     84.93%   84.88%   -0.06%     
+ Complexity     3716     3705      -11     
============================================
  Files           514      513       -1     
  Lines         12068    12024      -44     
  Branches       2271     2270       -1     
============================================
- Hits          10250    10206      -44     
+ Misses          698      691       -7     
- Partials       1120     1127       +7     
Impacted Files Coverage Δ
...tlab/arturbosch/detekt/rules/naming/ClassNaming.kt 94.73% <50.00%> (-5.27%) ⬇️
...b/arturbosch/detekt/rules/naming/VariableNaming.kt 88.57% <50.00%> (-7.99%) ⬇️
...sch/detekt/rules/naming/FunctionParameterNaming.kt 89.28% <60.00%> (-6.55%) ⬇️
.../detekt/rules/naming/ConstructorParameterNaming.kt 94.44% <84.61%> (-2.33%) ⬇️
...b/arturbosch/detekt/rules/naming/NamingProvider.kt 100.00% <100.00%> (ø)
...io/gitlab/arturbosch/detekt/core/rules/RuleSets.kt 93.10% <0.00%> (-6.90%) ⬇️
...ab/arturbosch/detekt/rules/naming/PackageNaming.kt 94.44% <0.00%> (-5.56%) ⬇️
...t/rules/naming/NonBooleanPropertyPrefixedWithIs.kt 76.92% <0.00%> (-5.13%) ⬇️
...otlin/io/gitlab/arturbosch/detekt/core/Analyzer.kt 80.89% <0.00%> (-1.13%) ⬇️
...rturbosch/detekt/rules/naming/VariableMinLength.kt 88.88% <0.00%> (+5.55%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@BraisGabin
Copy link
Copy Markdown
Member

@cortinico is there anything else that should be changed here?

@cortinico
Copy link
Copy Markdown
Member

@cortinico is there anything else that should be changed here?

Nope we can merge it 👍

@cortinico cortinico merged commit c435739 into detekt:main Sep 10, 2022
@BraisGabin
Copy link
Copy Markdown
Member

@VovaStelmashchuk Thanks for this PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants