Remove rule from NamingRules multi rule#5212
Merged
Merged
Conversation
added 2 commits
August 10, 2022 12:40
7 tasks
Contributor
Author
|
@marschwar The merge request ready for review. |
cortinico
requested changes
Aug 17, 2022
BraisGabin
approved these changes
Aug 21, 2022
Codecov Report
@@ Coverage Diff @@
## main #5212 +/- ##
============================================
- Coverage 84.93% 84.88% -0.06%
+ Complexity 3716 3705 -11
============================================
Files 514 513 -1
Lines 12068 12024 -44
Branches 2271 2270 -1
============================================
- Hits 10250 10206 -44
+ Misses 698 691 -7
- Partials 1120 1127 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
5e74730 to
1871aac
Compare
Member
|
@cortinico is there anything else that should be changed here? |
cortinico
approved these changes
Sep 10, 2022
Member
Nope we can merge it 👍 |
Member
|
@VovaStelmashchuk Thanks for this PR :) |
Merged
This was referenced Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of #5192