Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the current classpath inside KotlinEnvironmentResolver #5275

Merged
merged 1 commit into from Sep 4, 2022

Conversation

BraisGabin
Copy link
Collaborator

@BraisGabin BraisGabin commented Sep 4, 2022

Clases like BaseRule are not resolved by our test engine KotlinEnvironmentResolver. That creates issues in #5182. I have snippet code there that compile but they don't have all the information in the BindingContext. @marschwar implemented #5188. But as we commented there it was odd to configure something for KotlinEnvironmentResolver that was not needed for the snipet compilation check.

This PR fixes exactly that. We add all the classpath that the curren thread has to KotlinEnvironmentResolver. That's what the "snippet check compiler" does.

Closes #5188

@BraisGabin BraisGabin merged commit 6b6d904 into main Sep 4, 2022
21 checks passed
@BraisGabin BraisGabin deleted the improve-test-utils branch September 4, 2022 20:40
@BraisGabin BraisGabin added this to the 1.22.0 milestone Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants