Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fail fast #5290

Merged
merged 3 commits into from Sep 10, 2022
Merged

Remove fail fast #5290

merged 3 commits into from Sep 10, 2022

Conversation

BraisGabin
Copy link
Collaborator

@BraisGabin BraisGabin commented Sep 10, 2022

Fail fast was deprecated on version (1.16.0)[https://github.com/detekt/detekt/releases/tag/v1.16.0] one and a half years ago. I think that it's safe for us to remove it. This could help for future refactors over our configuration.

Blocked by: #5292

@cortinico cortinico added this to the 1.22.0 milestone Sep 10, 2022
@cortinico cortinico added the notable changes Marker for notable changes in the changelog label Sep 10, 2022
3flex
3flex approved these changes Sep 10, 2022
Copy link
Collaborator

@3flex 3flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked, but are there any docs to update?

@BraisGabin
Copy link
Collaborator Author

I couldn't find any reference about it on the docs.

@BraisGabin BraisGabin merged commit 19eed8a into main Sep 10, 2022
21 checks passed
@BraisGabin BraisGabin deleted the remove-fail-fast branch September 10, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli core gradle-plugin notable changes Marker for notable changes in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants