Introduce configFile property on DetektGenerateTask#5308
Merged
schalkms merged 1 commit intodetekt:mainfrom Sep 17, 2022
Merged
Introduce configFile property on DetektGenerateTask#5308schalkms merged 1 commit intodetekt:mainfrom
schalkms merged 1 commit intodetekt:mainfrom
Conversation
3flex
force-pushed
the
generate-right-prop
branch
from
79b0eaf to
97a39c2
Compare
cortinico
approved these changes
Sep 17, 2022
schalkms
approved these changes
Sep 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects a few issues:
ConfigurableFileCollection. Replacing withRegularFilePropertyis more correct as the task only generates a single file, not a collection of files.configparameter is incorrectly annotated with@InputFiles, but task generates a file and doesn't use the values as an input at all.configparameter is annotated@Optional. This doesn't make sense - if the task is run, it should generate a file, and the config file parameter must have a value to achieve this.This deprecation is backwards compatible. When the
configparameter is removed from the task there will be a small code clean up required.