Skip to content

MaxLineLength: raw typo and test cleanup - #5315

Merged
BraisGabin merged 2 commits into
detekt:mainfrom
TWiStErRob:MaxLineLength_raw
Sep 19, 2022
Merged

MaxLineLength: raw typo and test cleanup#5315
BraisGabin merged 2 commits into
detekt:mainfrom
TWiStErRob:MaxLineLength_raw

Conversation

@TWiStErRob

@TWiStErRob TWiStErRob commented Sep 18, 2022

Copy link
Copy Markdown
Member

A typo and simple consistency improvements while investigating #5314.

(Most of the changes were inspired by similar changes done in #5171 by @BraisGabin.)

@3flex

This comment was marked as outdated.

@3flex

3flex commented Sep 18, 2022

Copy link
Copy Markdown
Member

Be careful with the PR description, it says "does not fix #5314" but GitHub only sees "fix #5314" and will (incorrectly) close that issue when this is merged.

EDIT: This was fixed by BraisGabin before merging, but leaving as an FYI for next time!

@BraisGabin
BraisGabin merged commit 4e6cd75 into detekt:main Sep 19, 2022
@BraisGabin BraisGabin added this to the 1.22.0 milestone Sep 19, 2022
@TWiStErRob
TWiStErRob deleted the MaxLineLength_raw branch September 19, 2022 09:02
@TWiStErRob

Copy link
Copy Markdown
Member Author

Ah, fair about the commit message, missed a word there, I was probably trying to be concise :)
Re GitHub closing "does not fix" - amazing... that feature is really simple then, I'll keep it in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants