Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxLineLength: raw typo and test cleanup #5315

Merged
merged 2 commits into from Sep 19, 2022

Conversation

TWiStErRob
Copy link
Member

@TWiStErRob TWiStErRob commented Sep 18, 2022

A typo and simple consistency improvements while investigating #5314.

(Most of the changes were inspired by similar changes done in #5171 by @BraisGabin.)

3flex
3flex approved these changes Sep 18, 2022
@3flex

This comment was marked as outdated.

@3flex
Copy link
Collaborator

3flex commented Sep 18, 2022

Be careful with the PR description, it says "does not fix #5314" but GitHub only sees "fix #5314" and will (incorrectly) close that issue when this is merged.

EDIT: This was fixed by BraisGabin before merging, but leaving as an FYI for next time!

@BraisGabin BraisGabin merged commit 4e6cd75 into detekt:main Sep 19, 2022
21 checks passed
@BraisGabin BraisGabin added this to the 1.22.0 milestone Sep 19, 2022
@TWiStErRob TWiStErRob deleted the MaxLineLength_raw branch September 19, 2022 09:02
@TWiStErRob
Copy link
Member Author

Ah, fair about the commit message, missed a word there, I was probably trying to be concise :)
Re GitHub closing "does not fix" - amazing... that feature is really simple then, I'll keep it in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants