Differentiate between correctable and non-correctable KtLint rules#5324
Merged
arturbosch merged 2 commits intomainfrom Sep 24, 2022
Merged
Differentiate between correctable and non-correctable KtLint rules#5324arturbosch merged 2 commits intomainfrom
arturbosch merged 2 commits intomainfrom
Conversation
cortinico
approved these changes
Sep 20, 2022
TWiStErRob
reviewed
Sep 20, 2022
TWiStErRob
reviewed
Sep 20, 2022
arturbosch
force-pushed
the
differentiate-between-correctable-ktlint-rules
branch
from
3fbbfcb to
b95eaa4
Compare
Member
Author
|
Please review again @cortinico @TWiStErRob |
TWiStErRob
approved these changes
Sep 23, 2022
Member
TWiStErRob
left a comment
TWiStErRob
left a comment
There was a problem hiding this comment.
I'm ok, up to you to split the test, or add tests for true as well (if not yet).
TWiStErRob
approved these changes
Sep 24, 2022
arturbosch
force-pushed
the
differentiate-between-correctable-ktlint-rules
branch
from
634ae9f to
c28b278
Compare
TWiStErRob
approved these changes
Sep 24, 2022
arturbosch
deleted the
differentiate-between-correctable-ktlint-rules
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IJ plugin allows to auto correct
CorrectableCodeSmellinstances.However some rules by KtLint are not meant to be auto corrected.
We should not report a
CorrectableCodeSmellfor these cases.Are there more KtLint rules of that sort?