-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differentiate between correctable and non-correctable KtLint rules #5324
Differentiate between correctable and non-correctable KtLint rules #5324
Conversation
...ting/src/test/kotlin/io/gitlab/arturbosch/detekt/formatting/RulesWhichCantBeCorrectedSpec.kt
Outdated
Show resolved
Hide resolved
detekt-formatting/src/main/kotlin/io/gitlab/arturbosch/detekt/formatting/FormattingRule.kt
Outdated
Show resolved
Hide resolved
3fbbfcb
to
b95eaa4
Compare
Please review again @cortinico @TWiStErRob |
detekt-formatting/src/main/kotlin/io/gitlab/arturbosch/detekt/formatting/FormattingRule.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok, up to you to split the test, or add tests for true
as well (if not yet).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice split
...ting/src/test/kotlin/io/gitlab/arturbosch/detekt/formatting/RulesWhichCantBeCorrectedSpec.kt
Outdated
Show resolved
Hide resolved
...ting/src/test/kotlin/io/gitlab/arturbosch/detekt/formatting/RulesWhichCantBeCorrectedSpec.kt
Outdated
Show resolved
Hide resolved
634ae9f
to
c28b278
Compare
The IJ plugin allows to auto correct
CorrectableCodeSmell
instances.However some rules by KtLint are not meant to be auto corrected.
We should not report a
CorrectableCodeSmell
for these cases.Are there more KtLint rules of that sort?