CanBeNonNullable: explain why the rule does what it does.#5332
Merged
Conversation
BraisGabin
approved these changes
Sep 22, 2022
Member
|
Thank you! This kind of improvement are very valuable and no that common. |
Member
Author
Just need to get into the habit of copy-pasting your comments to the rule kdoc 😉. I'll watch out on my issues if there are usable comments. I have a big bundle of #5331 similar issues coming up. (It's much simpler to explain something to someone else, than sitting down and writing docs.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on conversation in #5331 (closes #5331), @BraisGabin, I borrowed your thoughts.
The original explanation described what the rule does, but gave no clarity on why.