Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CanBeNonNullable: explain why the rule does what it does. #5332

Merged
merged 1 commit into from Sep 22, 2022

Conversation

TWiStErRob
Copy link
Member

@TWiStErRob TWiStErRob commented Sep 22, 2022

Based on conversation in #5331 (closes #5331), @BraisGabin, I borrowed your thoughts.

The original explanation described what the rule does, but gave no clarity on why.

@BraisGabin
Copy link
Collaborator

Thank you! This kind of improvement are very valuable and no that common.

@BraisGabin BraisGabin merged commit 3e6d1d0 into detekt:main Sep 22, 2022
21 checks passed
@TWiStErRob
Copy link
Member Author

TWiStErRob commented Sep 22, 2022

Thank you! This kind of improvement are very valuable and no that common.

Just need to get into the habit of copy-pasting your comments to the rule kdoc 😉. I'll watch out on my issues if there are usable comments. I have a big bundle of #5331 similar issues coming up.

(It's much simpler to explain something to someone else, than sitting down and writing docs.)

@TWiStErRob TWiStErRob deleted the CanBeNonNullable_desc branch September 22, 2022 14:12
@cortinico cortinico added this to the 1.22.0 milestone Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CanBeNonNullable false positive
3 participants