UnnecessaryNotNullCheck: fix false negative with smart casted arguments

[t-kameyama]

Fixes #5379

[cortinico]

Great stuff!

[cortinico]

Can we add a comment on this function with a couple of example of what it does?

[t-kameyama]

3cdd9ac

[BraisGabin]

Suggested change

if (bindingContext == BindingContext.EMPTY) return false

The rules annotated with @RequiresTypeResolution are not called by the core if the BindingContext is empty so we don't need this line any more.

[codecov]

Codecov Report

Merging #5380 (0ee3d04) into main (f87a72d) will increase coverage by 86.08%.
The diff coverage is 68.42%.

❗ Current head 0ee3d04 differs from pull request most recent head 3cdd9ac. Consider uploading reports for the commit 3cdd9ac to get more accurate results

@@             Coverage Diff             @@
##             main    #5380       +/-   ##
===========================================
+ Coverage        0   86.08%   +86.08%     
- Complexity      0     3642     +3642     
===========================================
  Files           0      515      +515     
  Lines           0    12101    +12101     
  Branches        0     2166     +2166     
===========================================
+ Hits            0    10417    +10417     
- Misses          0      611      +611     
- Partials        0     1073     +1073     

Impacted Files	Coverage Δ
...lin/io/gitlab/arturbosch/detekt/rules/TypeUtils.kt	53.33% <50.00%> (ø)
...turbosch/detekt/rules/bugs/NullableToStringCall.kt	85.71% <71.42%> (ø)
...bosch/detekt/rules/bugs/UnnecessaryNotNullCheck.kt	88.46% <82.35%> (ø)
...otlin/io/github/detekt/metrics/ComplexityMetric.kt	100.00% <0.00%> (ø)
...turbosch/detekt/rules/documentation/CommentUtil.kt	100.00% <0.00%> (ø)
.../io/gitlab/arturbosch/detekt/cli/runners/Runner.kt	100.00% <0.00%> (ø)
...arturbosch/detekt/generator/collection/KDocTags.kt	100.00% <0.00%> (ø)
...gitlab/arturbosch/detekt/api/AnnotationExcluder.kt	91.89% <0.00%> (ø)
...hub/detekt/metrics/processors/AbstractProcessor.kt	100.00% <0.00%> (ø)
...rturbosch/detekt/rules/style/OptionalWhenBraces.kt	94.11% <0.00%> (ø)
... and 508 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.