Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of MPP targets function for JVM-only projects #5383

Merged
merged 2 commits into from Oct 7, 2022

Conversation

3flex
Copy link
Collaborator

@3flex 3flex commented Oct 6, 2022

KotlinJvmProjectExtension is a KotlinSingleJavaTargetExtension and only has a single target, so using the MPP targets function is unnecessary.

See #5381 (comment) for background.

KotlinJvmProjectExtension is a KotlinSingleJavaTargetExtension and only
has a single target, so using the MPP `targets` function is unnecessary.
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #5383 (6801514) into main (075db1f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #5383   +/-   ##
=========================================
  Coverage     86.11%   86.11%           
  Complexity     3643     3643           
=========================================
  Files           515      515           
  Lines         12085    12085           
  Branches       2161     2161           
=========================================
  Hits          10407    10407           
  Misses          609      609           
  Partials       1069     1069           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cortinico cortinico added this to the 1.22.0 milestone Oct 7, 2022
@3flex 3flex merged commit 7027c27 into detekt:main Oct 7, 2022
23 checks passed
@3flex 3flex deleted the drop-pm20 branch October 7, 2022 00:19
Copy link
Contributor

@Goooler Goooler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, safe to land, same fix Goooler@c6b9550.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants