Remove usage of MPP targets function for JVM-only projects#5383
Merged
3flex merged 2 commits intodetekt:mainfrom Oct 7, 2022
Merged
Remove usage of MPP targets function for JVM-only projects#53833flex merged 2 commits intodetekt:mainfrom
3flex merged 2 commits intodetekt:mainfrom
Conversation
KotlinJvmProjectExtension is a KotlinSingleJavaTargetExtension and only has a single target, so using the MPP `targets` function is unnecessary.
Codecov Report
@@ Coverage Diff @@
## main #5383 +/- ##
=========================================
Coverage 86.11% 86.11%
Complexity 3643 3643
=========================================
Files 515 515
Lines 12085 12085
Branches 2161 2161
=========================================
Hits 10407 10407
Misses 609 609
Partials 1069 1069 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cortinico
approved these changes
Oct 7, 2022
Goooler
reviewed
Oct 7, 2022
Contributor
Goooler
left a comment
Goooler
left a comment
There was a problem hiding this comment.
LGTM, safe to land, same fix Goooler@c6b9550.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KotlinJvmProjectExtensionis aKotlinSingleJavaTargetExtensionand only has a single target, so using the MPPtargetsfunction is unnecessary.See #5381 (comment) for background.