Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --print-ast CLI flag as PsiViewer provides the same features #5418

Merged
merged 1 commit into from Oct 20, 2022

Conversation

schalkms
Copy link
Member

@schalkms schalkms commented Oct 15, 2022

Closes #5417

@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Merging #5418 (17a0f0b) into main (b620bd5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #5418      +/-   ##
============================================
- Coverage     85.97%   85.96%   -0.01%     
+ Complexity     3613     3608       -5     
============================================
  Files           514      513       -1     
  Lines         12055    12042      -13     
  Branches       2161     2158       -3     
============================================
- Hits          10364    10352      -12     
+ Misses          618      617       -1     
  Partials       1073     1073              
Impacted Files Coverage Δ
.../kotlin/io/gitlab/arturbosch/detekt/cli/CliArgs.kt 100.00% <ø> (ø)
...otlin/io/gitlab/arturbosch/detekt/cli/CliRunner.kt 7.69% <ø> (+0.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cortinico cortinico added the notable changes Marker for notable changes in the changelog label Oct 16, 2022
@cortinico cortinico added this to the 1.22.0 milestone Oct 16, 2022
3flex
3flex approved these changes Oct 16, 2022
@BraisGabin
Copy link
Collaborator

As a side note, @samuelneff, even we don't want to keep the maintenance of these feel free to copy these code and create your own stand-alone cli for printing the ast tree.

And I think that ktlint has this feature on their cli too so that's other option.

@schalkms schalkms merged commit 5c7f6ec into main Oct 20, 2022
23 checks passed
@schalkms schalkms deleted the print-ast-cli branch October 20, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli notable changes Marker for notable changes in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancements to --print-ast
4 participants