BooleanPropertyNaming highlight only the name of the variable #5431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TWiStErRob
commented
Oct 17, 2022
...naming/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/naming/BooleanPropertyNamingSpec.kt
Show resolved
Hide resolved
TWiStErRob
commented
Oct 17, 2022
| @@ -79,7 +79,7 @@ class BooleanPropertyNaming(config: Config = Config.empty) : Rule(config) { | |||
| val description = "Boolean property name should match a $allowedPattern pattern." | |||
| return CodeSmell( | |||
| issue, | |||
| Entity.from(declaration), | |||
| Entity.from(declaration.nameIdentifier ?: declaration), | |||
There was a problem hiding this comment.
Could this be statically checked in the new ruleset as a best practice? e.g. if the "thing" passed into Entity.from has a "name" (e.g. inherits from PsiNameIdentifierOwner), then report("use '.nameIdentifier' instead")?
There was a problem hiding this comment.
I'm not sure if this could apply to all the cases. But that seems like a doable rule so anyone can implement it and check if my statment is true.
TWiStErRob
commented
Oct 17, 2022
...les-naming/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/naming/BooleanPropertyNaming.kt
Show resolved
Hide resolved
TWiStErRob
force-pushed
the
BooleanPropertyNaming_highlight
branch
from
255d6eb to
e0514d9
Compare
BraisGabin
reviewed
Oct 19, 2022
| @@ -79,7 +79,7 @@ class BooleanPropertyNaming(config: Config = Config.empty) : Rule(config) { | |||
| val description = "Boolean property name should match a $allowedPattern pattern." | |||
| return CodeSmell( | |||
| issue, | |||
| Entity.from(declaration), | |||
| Entity.from(declaration.nameIdentifier ?: declaration), | |||
There was a problem hiding this comment.
I'm not sure if this could apply to all the cases. But that seems like a doable rule so anyone can implement it and check if my statment is true.
...les-naming/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/naming/BooleanPropertyNaming.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Brais Gabín <braisgabin@gmail.com>
BraisGabin
approved these changes
Oct 19, 2022
schalkms
approved these changes
Oct 20, 2022
cortinico
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... the usual, the warning hides too much, but also deeplinking is broken, e.g. clicking on the this code location:
brings me to (before)
(expected)
