Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting for CascadingCallWrapping #5439

Merged

Conversation

dimsuz
Copy link
Contributor

@dimsuz dimsuz commented Oct 18, 2022

Make the error report point of failure more precisely by highlighting the exact part of expression which should be wrapped to a new line

Closes #5043

Make the error report point of failure more precisely by highlighting
the exact part of expression which should be wrapped to a new line

Closes detekt#5043
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #5439 (202c821) into main (37ce264) will increase coverage by 85.95%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##             main    #5439       +/-   ##
===========================================
+ Coverage        0   85.95%   +85.95%     
- Complexity      0     3616     +3616     
===========================================
  Files           0      514      +514     
  Lines           0    12067    +12067     
  Branches        0     2165     +2165     
===========================================
+ Hits            0    10372    +10372     
- Misses          0      619      +619     
- Partials        0     1076     +1076     
Impacted Files Coverage Δ
...rbosch/detekt/rules/style/CascadingCallWrapping.kt 70.90% <66.66%> (ø)
.../arturbosch/detekt/core/baseline/BaselineFormat.kt 89.18% <0.00%> (ø)
...ain/kotlin/io/gitlab/arturbosch/detekt/api/Debt.kt 100.00% <0.00%> (ø)
.../arturbosch/detekt/core/reporting/ReportLocator.kt 92.30% <0.00%> (ø)
...bosch/detekt/formatting/wrappers/StringTemplate.kt 100.00% <0.00%> (ø)
...ator/printer/defaultconfig/RuleSetConfigPrinter.kt 92.30% <0.00%> (ø)
...urbosch/detekt/generator/collection/Annotations.kt 66.66% <0.00%> (ø)
...osch/detekt/formatting/wrappers/CommentWrapping.kt 100.00% <0.00%> (ø)
...urbosch/detekt/formatting/EditorConfigConstants.kt 0.00% <0.00%> (ø)
...in/io/gitlab/arturbosch/detekt/api/SingleAssign.kt 83.33% <0.00%> (ø)
... and 505 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@BraisGabin BraisGabin added this to the 1.22.0 milestone Oct 19, 2022
@BraisGabin BraisGabin merged commit d643963 into detekt:main Oct 19, 2022
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CascadingCallWrapping] Doesn't report the point of the failure
3 participants