Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ruleauthors rule for Entity.from(x.nameIdentifier ?: x) -> Entity.atName(x) #5444

Merged
merged 11 commits into from Oct 25, 2022

Conversation

TWiStErRob
Copy link
Member

Motivation: automated "code review" for this:
#5431 (comment)

detekt-rules-libraries\src\main\kotlin\io\gitlab\arturbosch\detekt\libraries\ForbiddenPublicDataClass.kt:60:48: Recommended to use Entity.atName(klass) instead. [UseNamedLocation]
detekt-rules-naming\src\main\kotlin\io\gitlab\arturbosch\detekt\rules\naming\EnumNaming.kt:37:28: Recommended to use Entity.atName(enumEntry) instead. [UseNamedLocation]
detekt-rules-complexity\src\main\kotlin\io\gitlab\arturbosch\detekt\rules\complexity\TooManyFunctions.kt:144:28: Recommended to use Entity.atName(declaration) instead. [UseNamedLocation]
detekt-rules-style\src\main\kotlin\io\gitlab\arturbosch\detekt\rules\style\UseDataClass.kt:106:32: Recommended to use Entity.atName(klass) instead. [UseNamedLocation]
@github-actions
Copy link

github-actions bot commented Oct 19, 2022

Messages
📖 Thanks for adding a new rule to Detekt ❤️

Generated by 🚫 dangerJS against c4df600

Copy link
Collaborator

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one :)

@BraisGabin BraisGabin added this to the 1.22.0 milestone Oct 19, 2022
@BraisGabin BraisGabin merged commit 0b087ec into detekt:main Oct 25, 2022
21 checks passed
@TWiStErRob TWiStErRob deleted the nameIdentifier branch October 25, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants