Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make detekt less noisy #5448

Merged
merged 2 commits into from Oct 20, 2022
Merged

Make detekt less noisy #5448

merged 2 commits into from Oct 20, 2022

Conversation

BraisGabin
Copy link
Collaborator

Fixes #5436 (at least the regression part)

@Deprecated(
"You should pass a printStream",
ReplaceWith("createKotlinCoreEnvironment(configuration, disposable, System.err)")
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    printStream: PrintStream = System.err,

wouldn't work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would. But that would break binary compatibility.

And I'm not a big fan of the default values, too be honest.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed there, but when there's two other default values already :)

a @JvmOverloads would help with binary compat I think, and one less method, and one less deprecation warning to action for users.

@BraisGabin BraisGabin merged commit ec6cd40 into main Oct 20, 2022
21 checks passed
@BraisGabin BraisGabin deleted the fix-5436 branch October 20, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detekt 1.22.0 is getting noisier and noisier
3 participants