Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show the number of issues generating the BindingContext #5449

Merged
merged 1 commit into from Oct 20, 2022

Conversation

BraisGabin
Copy link
Collaborator

@BraisGabin BraisGabin commented Oct 19, 2022

This PR fixes the "no regression" part of #5436


fun printIssuesCountIfAny() {
if (messages > 0) {
warningPrinter(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than fully killing put it behind the debug? or does that already print the number of problems? I should probably check 😂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double-checked, when running with debug mode, it doesn't print the number of compilation errors, just lists them all. Since the numbers are high, and they can fluctuate, I think it would be beneficial to print the number of them, although that's probably not in scope here. (javac does print error and apt problem count, but kotlinc doesn't)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope as you said. We are removing this because no one cares. If someone wants it I'll be happy to review the pr but otherwise it seems a YAGNI.

@BraisGabin BraisGabin merged commit eef1dfa into main Oct 20, 2022
21 checks passed
@BraisGabin BraisGabin deleted the fix-5436_2 branch October 20, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants