FunctionMaxLength false positive for overridden methods #5590

[mmorozkov]

By analogy with other naming rules a new ignoreOverridden property with default value true was introduced for following rules:

• FunctionMaxLength
• FunctionMinLength
• VariableMaxLength
• VariableMinLength

[codecov]

Codecov Report

Merging #5599 (ed15090) into main (8aa1c82) will increase coverage by 85.90%.
The diff coverage is 100.00%.

❗ Current head ed15090 differs from pull request most recent head 9aaa17d. Consider uploading reports for the commit 9aaa17d to get more accurate results

@@             Coverage Diff             @@
##             main    #5599       +/-   ##
===========================================
+ Coverage        0   85.90%   +85.90%     
- Complexity      0     3645     +3645     
===========================================
  Files           0      516      +516     
  Lines           0    12191    +12191     
  Branches        0     2175     +2175     
===========================================
+ Hits            0    10473    +10473     
- Misses          0      628      +628     
- Partials        0     1090     +1090     

Impacted Files	Coverage Δ
...rturbosch/detekt/rules/naming/FunctionMaxLength.kt	100.00% <100.00%> (ø)
...rturbosch/detekt/rules/naming/FunctionMinLength.kt	100.00% <100.00%> (ø)
...rturbosch/detekt/rules/naming/VariableMaxLength.kt	100.00% <100.00%> (ø)
...rturbosch/detekt/rules/naming/VariableMinLength.kt	90.47% <100.00%> (ø)
...in/io/gitlab/arturbosch/detekt/api/SplitPattern.kt	100.00% <0.00%> (ø)
...sch/detekt/generator/printer/RuleSetPagePrinter.kt	75.00% <0.00%> (ø)
...lab/arturbosch/detekt/generator/collection/Rule.kt	100.00% <0.00%> (ø)
...wrappers/SpacingBetweenDeclarationsWithComments.kt	100.00% <0.00%> (ø)
...ppers/SpacingBetweenDeclarationsWithAnnotations.kt	100.00% <0.00%> (ø)
...etekt/core/tooling/ProcessingSpecSettingsBridge.kt	93.33% <0.00%> (ø)
... and 510 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[BraisGabin]

Thanks! LGTM

I see that you copied the description of this parameter from other rules so we should merge this as it is. But probably we could improve the description on other pr. More than function with the override modifier I would call them override functions.

[BraisGabin]

Fixes #5590

[TWiStErRob]

@BraisGabin putting "fixes" in a comment, doesn't trigger GitHub to pick it up, it has to be in OP, or manually linked in the sidebar. (I added it manually)