ExplicitCollectionElementAccessMethod rule update #5654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix false positive in ExplicitCollectionElementAccessMethod by checking if any parameter(excluding the first) is spread parameter if yes then return false as we can use access method syntax with spread parameter
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BraisGabin
reviewed
Jan 1, 2023
...main/kotlin/io/gitlab/arturbosch/detekt/rules/style/ExplicitCollectionElementAccessMethod.kt
Outdated
Show resolved
Hide resolved
BraisGabin
approved these changes
Jan 1, 2023
.../kotlin/io/gitlab/arturbosch/detekt/rules/style/ExplicitCollectionElementAccessMethodSpec.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Brais Gabín <braisgabin@gmail.com>
cortinico
reviewed
Jan 2, 2023
...main/kotlin/io/gitlab/arturbosch/detekt/rules/style/ExplicitCollectionElementAccessMethod.kt
Outdated
Show resolved
Hide resolved
.../kotlin/io/gitlab/arturbosch/detekt/rules/style/ExplicitCollectionElementAccessMethodSpec.kt
Outdated
Show resolved
Hide resolved
atulgpt
requested review from
BraisGabin and
cortinico
and removed request for
BraisGabin
BraisGabin
reviewed
Jan 4, 2023
| @@ -96,6 +100,7 @@ class ExplicitCollectionElementAccessMethod(config: Config = Config.empty) : Rul | |||
| return function.isOperator | |||
| } | |||
|
|
|||
| @Suppress("ReturnCount") | |||
There was a problem hiding this comment.
Why is this suppress needed? It wasn't needed before and you didn't add any new code to this function
There was a problem hiding this comment.
It was already giving the warning as it has three return statements(while only 2 are allowed). I suppressed the warning
|
Hi, @BraisGabin/ @cortinico this is good for a merge if we can close the comment thread at #5654 (comment). Also, want to know what is the process of the merge. Will one of the maintainers be merging this PR or if approved, the author can merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5640