Check Thread.sleep for block expression

[atulgpt]

Fixes #5659
Add check of canGoInside when lambda argument is suspend

[BraisGabin]

👏👏👏 Good one! 👏👏👏 Thanks :)

[BraisGabin]

@atulgpt could you check CI? It seems that the snippets doesn't compile. Once that's fixed this is ready to merge.

[github-actions]

	Warnings
⚠️	This PR is approved with no milestone set. If merged, it won't appear in the Detekt release notes.

Generated by 🚫 dangerJS against 53fbb90

[atulgpt]

Hi @BraisGabin, updated the PR(also reworked the traversal logic as in the previous logic some newly added TCs were failing)

@cortinico at the comment #5666 (comment) I told about there are some bugs in coroutine related rule(some not honoring suspend operator and some not handling inline and other types of lambda). In this rule, there was not any possibility of suspend operator error but this had a few issues with handling inline, noinline and crossinline modifiers which I fixed with this PR

[codecov]

Codecov Report

Merging #5699 (53fbb90) into main (cb6a705) will decrease coverage by 0.03%.
The diff coverage is 70.73%.

@@             Coverage Diff              @@
##               main    #5699      +/-   ##
============================================
- Coverage     84.59%   84.57%   -0.03%     
+ Complexity     3790     3786       -4     
============================================
  Files           546      546              
  Lines         12918    12937      +19     
  Branches       2268     2273       +5     
============================================
+ Hits          10928    10941      +13     
- Misses          861      863       +2     
- Partials       1129     1133       +4     

Impacted Files	Coverage Δ
...sch/detekt/rules/coroutines/SleepInsteadOfDelay.kt	74.00% <70.73%> (-1.87%)	⬇️
.../detekt/rules/naming/ConstructorParameterNaming.kt	88.57% <0.00%> (-0.32%)	⬇️
...bosch/detekt/rules/naming/BooleanPropertyNaming.kt	94.11% <0.00%> (-0.17%)	⬇️
...b/arturbosch/detekt/rules/naming/FunctionNaming.kt	100.00% <0.00%> (ø)
...b/arturbosch/detekt/rules/naming/VariableNaming.kt	88.57% <0.00%> (ø)
...sch/detekt/rules/naming/FunctionParameterNaming.kt	89.28% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[atulgpt]

Hi @BraisGabin , some intermittent error in CI can you retrigger?