Skip to content

IgnoredReturnValue: fix false negative when annotation is on the package - #5706

Merged
schalkms merged 1 commit into
detekt:mainfrom
t-kameyama:issue_5686
Jan 20, 2023
Merged

IgnoredReturnValue: fix false negative when annotation is on the package#5706
schalkms merged 1 commit into
detekt:mainfrom
t-kameyama:issue_5686

Conversation

@t-kameyama

Copy link
Copy Markdown
Contributor

Fixes #5686

@codecov

codecov Bot commented Jan 18, 2023

Copy link
Copy Markdown

Codecov Report

Merging #5706 (769718e) into main (4d6b0f4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #5706   +/-   ##
=========================================
  Coverage     84.45%   84.46%           
  Complexity     3733     3733           
=========================================
  Files           543      543           
  Lines         12701    12709    +8     
  Branches       2222     2222           
=========================================
+ Hits          10727    10735    +8     
  Misses          865      865           
  Partials       1109     1109           
Impacted Files Coverage Δ
...arturbosch/detekt/rules/bugs/IgnoredReturnValue.kt 90.56% <100.00%> (+1.67%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@BraisGabin BraisGabin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@BraisGabin BraisGabin added this to the 1.23.0 milestone Jan 18, 2023
@schalkms
schalkms merged commit d0a4737 into detekt:main Jan 20, 2023
@t-kameyama
t-kameyama deleted the issue_5686 branch January 20, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IgnoredReturnValue false negative when annotation is on the package.

3 participants