Fix false positive for `CanBeNonNullable` rule #5714

atulgpt · 2023-01-20T21:17:01Z

Added failing TCs
Fixes #5629

BraisGabin · 2023-02-21T10:21:35Z

Are these tests related with #5629? The cases are a bit difficult to follow. And I'm not sure if all of them are related with the same issue.

Would it be possible to split them in different PRs? Or all of them target the same flaw?

atulgpt · 2023-02-21T11:35:50Z

Hi, @BraisGabin not all follow the same flaw. Some can be grouped and split into little PRs. Is there any provision to add a disabled test in the PR? Or should I completely remove them from here and add in the other PRs?

Also only see the TCs with // Failing comments as only those TCs are failing

BraisGabin · 2023-02-21T11:39:59Z

I would prefer to split them up.

...-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/CanBeNonNullableSpec.kt

BraisGabin

Hi @atulgpt which are the next steps for this PR? Is there somerhing blocking you here? Can I help you some how? I left some comments on the tests but they seem fine.

I must say that a function that only does something when a parameter is null seems like a function that should be flagged too. But probably not by this rule but by other one. But this is offtopic for this PR.

...-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/CanBeNonNullableSpec.kt

BraisGabin · 2023-03-03T23:37:13Z

...-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/CanBeNonNullableSpec.kt

+                            }
+                        }
+                    """.trimIndent()
+                    assertThat(subject.compileAndLintWithContext(env, code)).hasSize(1)


I dont't get what this test does exactly.

The name of the TC was wrong. Actually, it should report as all the branches of when handles the non-null case. Here we are checking different types of boolean conditions. I have renamed the TC to does report when parameter is not checked for nullability in boolean conditions

...-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/CanBeNonNullableSpec.kt

atulgpt · 2023-03-07T03:17:00Z

Hi @atulgpt which are the next steps for this PR? Is there somerhing blocking you here? Can I help you some how? I left some comments on the tests but they seem fine.

I must say that a function that only does something when a parameter is null seems like a function that should be flagged too. But probably not by this rule but by other one. But this is offtopic for this PR.

Hi @BraisGabin good vibes of Bali is stopping me from completing this PR 😂. I will complete back after I come back 🙂

BraisGabin · 2023-03-08T00:34:56Z

Hi @BraisGabin good vibes of Bali is stopping me from completing this PR 😂. I will complete back after I come back 🙂

Enjoy!!!

codecov · 2023-03-25T14:37:18Z

Codecov Report

Merging #5714 (f9f8b8b) into main (33d0230) will increase coverage by 0.06%.
The diff coverage is 87.50%.

@@             Coverage Diff              @@
##               main    #5714      +/-   ##
============================================
+ Coverage     84.57%   84.63%   +0.06%     
- Complexity     3786     3788       +2     
============================================
  Files           546      546              
  Lines         12938    12943       +5     
  Branches       2275     2275              
============================================
+ Hits          10942    10954      +12     
- Misses          862      866       +4     
+ Partials       1134     1123      -11

Impacted Files	Coverage Δ
.../arturbosch/detekt/rules/style/CanBeNonNullable.kt	`80.07% <87.50%> (+7.24%)`	⬆️

... and 19 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/CanBeNonNullable.kt

Fix violations Add PR TC

BraisGabin

I left some nit comments but LGTM

detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/CanBeNonNullable.kt

…/rules/style/CanBeNonNullable.kt Co-authored-by: Brais Gabín <braisgabin@gmail.com>

BraisGabin · 2023-03-29T21:46:43Z

It seems that my code didn't compile 😅. The Github's suggestions feature is great but working without an IDE is difficult.

atulgpt · 2023-04-01T19:09:12Z

It seems that my code didn't compile 😅. The Github's suggestions feature is great but working without an IDE is difficult.

Haha true 😅 I have fixed it to make it compliable. Now CI should pass

github-actions bot added the rules label Jan 20, 2023

atulgpt mentioned this pull request Jan 20, 2023

CanBeNonNullable false positive #5629

Closed

atulgpt changed the title ~~Add failing TCs~~ Add failing TCs for CanBeNonNullable rule Jan 20, 2023

vercel bot deployed to Preview January 20, 2023 21:23 View deployment

Add failing TCs

56f4987

atulgpt force-pushed the fixes-5629 branch from a253e35 to 56f4987 Compare February 28, 2023 21:20

github-advanced-security bot found potential problems Feb 28, 2023

View reviewed changes

vercel bot deployed to Preview February 28, 2023 21:25 View deployment

BraisGabin reviewed Mar 3, 2023

View reviewed changes

vercel bot deployed to Preview March 13, 2023 12:46 View deployment

atulgpt force-pushed the fixes-5629 branch 2 times, most recently from 4285945 to c064724 Compare March 25, 2023 14:34

atulgpt force-pushed the fixes-5629 branch from c064724 to 5df2c49 Compare March 25, 2023 14:38

github-advanced-security bot found potential problems Mar 25, 2023

View reviewed changes

detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/CanBeNonNullable.kt Fixed Show fixed Hide fixed

detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/CanBeNonNullable.kt Fixed Show fixed Hide fixed

vercel bot deployed to Preview March 25, 2023 14:43 View deployment

atulgpt commented Mar 25, 2023

View reviewed changes

detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/CanBeNonNullable.kt Outdated Show resolved Hide resolved

atulgpt marked this pull request as ready for review March 25, 2023 14:56

Fix issue by finding the all name ref for a var

16038a9

Fix violations Add PR TC

atulgpt force-pushed the fixes-5629 branch from 5df2c49 to 16038a9 Compare March 25, 2023 14:59

vercel bot deployed to Preview March 25, 2023 15:03 View deployment

BraisGabin approved these changes Mar 27, 2023

View reviewed changes

detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/CanBeNonNullable.kt Outdated Show resolved Hide resolved

detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/CanBeNonNullable.kt Outdated Show resolved Hide resolved

BraisGabin added this to the 1.23.0 milestone Mar 27, 2023

atulgpt and others added 2 commits March 28, 2023 13:56

Update detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt…

d84afe5

…/rules/style/CanBeNonNullable.kt Co-authored-by: Brais Gabín <braisgabin@gmail.com>

Rename subjectDescriptor to subjectDescriptors

3ec61ec

vercel bot had a problem deploying to Preview March 28, 2023 08:35 Failure

Fix non-compiling code

f9f8b8b

vercel bot deployed to Preview April 1, 2023 19:14 View deployment

cortinico approved these changes Apr 6, 2023

View reviewed changes

cortinico changed the title ~~Add failing TCs for CanBeNonNullable rule~~ Fix false positive for CanBeNonNullable rule Apr 6, 2023

cortinico merged commit 5cdd952 into detekt:main Apr 6, 2023
23 checks passed

atulgpt deleted the fixes-5629 branch April 6, 2023 18:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix false positive for `CanBeNonNullable` rule #5714

Fix false positive for `CanBeNonNullable` rule #5714

atulgpt commented Jan 20, 2023 •

edited by cortinico

BraisGabin commented Feb 21, 2023

atulgpt commented Feb 21, 2023 •

edited

BraisGabin commented Feb 21, 2023

BraisGabin left a comment

BraisGabin Mar 3, 2023

atulgpt Mar 14, 2023

atulgpt commented Mar 7, 2023

BraisGabin commented Mar 8, 2023

codecov bot commented Mar 25, 2023 •

edited

BraisGabin left a comment

BraisGabin commented Mar 29, 2023

atulgpt commented Apr 1, 2023

Fix false positive for CanBeNonNullable rule #5714

Fix false positive for CanBeNonNullable rule #5714

Conversation

atulgpt commented Jan 20, 2023 • edited by cortinico

BraisGabin commented Feb 21, 2023

atulgpt commented Feb 21, 2023 • edited

BraisGabin commented Feb 21, 2023

BraisGabin left a comment

Choose a reason for hiding this comment

BraisGabin Mar 3, 2023

Choose a reason for hiding this comment

atulgpt Mar 14, 2023

Choose a reason for hiding this comment

atulgpt commented Mar 7, 2023

BraisGabin commented Mar 8, 2023

codecov bot commented Mar 25, 2023 • edited

Codecov Report

BraisGabin left a comment

Choose a reason for hiding this comment

BraisGabin commented Mar 29, 2023

atulgpt commented Apr 1, 2023

Fix false positive for `CanBeNonNullable` rule #5714

Fix false positive for `CanBeNonNullable` rule #5714

atulgpt commented Jan 20, 2023 •

edited by cortinico

atulgpt commented Feb 21, 2023 •

edited

codecov bot commented Mar 25, 2023 •

edited