UnusedPrivateMember - Fix false positive in case of invoke operator

[atulgpt]

Fixes #4435

[codecov]

Codecov Report

Merging #5717 (bddd6e0) into main (b616a2f) will decrease coverage by 0.01%.
The diff coverage is 84.81%.

@@             Coverage Diff              @@
##               main    #5717      +/-   ##
============================================
- Coverage     84.59%   84.58%   -0.01%     
- Complexity     3768     3788      +20     
============================================
  Files           546      547       +1     
  Lines         12817    12894      +77     
  Branches       2236     2258      +22     
============================================
+ Hits          10842    10906      +64     
- Misses          860      861       +1     
- Partials       1115     1127      +12     

Impacted Files	Coverage Δ
...osch/detekt/rules/style/StringShouldBeRawString.kt	84.21% <84.21%> (ø)
...turbosch/detekt/rules/style/UnusedPrivateMember.kt	89.90% <85.71%> (-2.32%)	⬇️
...rturbosch/detekt/rules/style/StyleGuideProvider.kt	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[atulgpt]

Hi, @BraisGabin / @TWiStErRob / @cortinico can you guys review this PR :) Let me know if any changes are required

[BraisGabin]

LGTM Thanks!

[BraisGabin]

Sorry for the delay. Could you fix the conflicts? I think they are going to be big because this rule was splitted in 3. But the test and code looks good :)

[atulgpt]

Hi @BraisGabin one test RedundantVisibilityModifierRuleSpec > Explicit API mode > does not report public function in class if explicit API mode is set to strict() is failing while in the local same test is getting passes. Any idea how to make CI happy?

[BraisGabin]

No idea, I'm re-running the task to see if it still happens.

[atulgpt]

@BraisGabin seemed like an intermittent issue. It got passed now. Pasting the stack trace of the intermittent failure below

RedundantVisibilityModifierRuleSpec > Explicit API mode > does not report public function in class if explicit API mode is set to strict() FAILED
    io.mockk.MockKException: Can't instantiate proxy for class org.jetbrains.kotlin.config.LanguageVersionSettings
        at io.mockk.impl.instantiation.JvmMockFactory.newProxy(JvmMockFactory.kt:64)
        at io.mockk.impl.instantiation.AbstractMockFactory.newProxy$default(AbstractMockFactory.kt:24)
        at io.mockk.impl.instantiation.AbstractMockFactory.mockk(AbstractMockFactory.kt:59)
        at io.gitlab.arturbosch.detekt.rules.style.RedundantVisibilityModifierRuleSpec$Explicit API mode.mockCompilerResources(RedundantVisibilityModifierRuleSpec.kt:236)
        at io.gitlab.arturbosch.detekt.rules.style.RedundantVisibilityModifierRuleSpec$Explicit API mode.does not report public function in class if explicit API mode is set to strict(RedundantVisibilityModifierRuleSpec.kt:205)

        Caused by:
        io.mockk.proxy.MockKAgentException: Value for this result is not assigned
            at io.mockk.proxy.common.CancelableResult.get(CancelableResult.kt:18)
            at io.mockk.impl.instantiation.JvmMockFactory.newProxy(JvmMockFactory.kt:44)
            ... 4 more

logs at here

[BraisGabin]

It seems like an issue at mockk. I saw some issues related with that exception message at their repo. Anyway, merging!