Remove ignoreOverridden config from BooleanPropertyNaming etc.

[drawers]

Fixes #5600 where it was agreed to remove ignoreOverridden from 5 rules:

1. BooleanPropertyNaming
2. ConstructorParameterNaming
3. FunctionNaming
4. VariableNaming
5. FunctionParameterNaming

[codecov]

Codecov Report

Merging #5718 (ba2cc61) into main (6d7e7e6) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##               main    #5718      +/-   ##
============================================
- Coverage     84.59%   84.59%   -0.01%     
+ Complexity     3790     3776      -14     
============================================
  Files           546      546              
  Lines         12918    12916       -2     
  Branches       2268     2268              
============================================
- Hits          10928    10926       -2     
  Misses          861      861              
  Partials       1129     1129              

Impacted Files	Coverage Δ
...sch/detekt/rules/naming/FunctionParameterNaming.kt	89.28% <0.00%> (ø)
...bosch/detekt/rules/naming/BooleanPropertyNaming.kt	94.11% <100.00%> (-0.17%)	⬇️
.../detekt/rules/naming/ConstructorParameterNaming.kt	88.57% <100.00%> (-0.32%)	⬇️
...b/arturbosch/detekt/rules/naming/FunctionNaming.kt	100.00% <100.00%> (ø)
...b/arturbosch/detekt/rules/naming/VariableNaming.kt	88.57% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[schalkms]

Looks good! Thanks for tidying up!

[schalkms]

@BraisGabin do you want to review this, since you brought up this improvement?

[BraisGabin]

Thanks for the PR! And sorry for the late review. If you could fix what I point out in my other comment we can merge this.

[BraisGabin]

This is a "breaking change". It is not in the "normal way" but we treat the yaml configuration as part of our public API.

Instead of removing the property, just keep it and add it this annotation @Deprecated("This configuration is ignored") (I'm not inspired with my descriptions feel free to improve it).

Other option is to add the deprecation atio.gitlab.arturbosch.detekt.generator.printer.writeMigratedRules. This way we keep the code clean.

What bothe options does is to keep detekt-core/src/main/resources/deprecation.properties up to date with old the deprecations.

[drawers]

Thanks, that's a clever way to manage deprecation. I have assumed that between the two ways of doing things you have stated, the first way is cleaner because the code is kept in sync with the deprecation.properties.

I just need to rebase this on the latest main before we review again. I will ping later today when it is ready 🙏

[drawers]

Thanks @BraisGabin I think this is ready for you to have another look at now

[github-advanced-security]

detekt found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

[BraisGabin]

Thanks! LGTM