Skip to content

Fail when unexpected version of kotlin-compiler-embeddable is on runtime classpath - #5726

Merged
schalkms merged 5 commits into
detekt:mainfrom
3flex:5645-fix
Feb 4, 2023
Merged

Fail when unexpected version of kotlin-compiler-embeddable is on runtime classpath#5726
schalkms merged 5 commits into
detekt:mainfrom
3flex:5645-fix

Conversation

@3flex

@3flex 3flex commented Jan 26, 2023

Copy link
Copy Markdown
Member

Fixes #5645
Closes #5551

@codecov

codecov Bot commented Jan 26, 2023

Copy link
Copy Markdown

Codecov Report

Merging #5726 (e932069) into main (3310798) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #5726      +/-   ##
============================================
+ Coverage     84.46%   84.52%   +0.06%     
+ Complexity     3736     3734       -2     
============================================
  Files           543      544       +1     
  Lines         12716    12753      +37     
  Branches       2223     2229       +6     
============================================
+ Hits          10741    10780      +39     
  Misses          865      865              
+ Partials       1110     1108       -2     
Impacted Files Coverage Δ
.../gitlab/arturbosch/detekt/api/internal/Versions.kt 90.00% <100.00%> (+2.50%) ⬆️
...otlin/io/gitlab/arturbosch/detekt/core/Analyzer.kt 85.43% <100.00%> (+0.97%) ⬆️
...osch/detekt/core/tooling/DefaultVersionProvider.kt 100.00% <100.00%> (+50.00%) ⬆️
...n/io/github/detekt/report/html/HtmlOutputReport.kt 96.73% <100.00%> (+1.08%) ⬆️
...n/kotlin/io/github/detekt/report/html/HtmlUtils.kt 100.00% <100.00%> (+1.66%) ⬆️
...otlin/io/github/detekt/report/md/MdOutputReport.kt 98.91% <100.00%> (+1.08%) ⬆️
...turbosch/detekt/rules/bugs/PotentialBugProvider.kt 100.00% <0.00%> (ø)
...detekt/rules/bugs/CastNullableToNonNullableType.kt 92.00% <0.00%> (ø)
...turbosch/detekt/rules/bugs/NullableToStringCall.kt 89.18% <0.00%> (+3.47%) ⬆️
...lin/io/gitlab/arturbosch/detekt/rules/TypeUtils.kt 65.51% <0.00%> (+12.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment thread website/docs/gettingstarted/gradle.mdx
Comment thread detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/internal/Versions.kt Outdated
Comment thread detekt-cli/src/main/kotlin/io/gitlab/arturbosch/detekt/cli/Main.kt
@github-actions github-actions Bot added the core label Jan 26, 2023

@schalkms schalkms left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@schalkms schalkms added this to the 1.23.0 milestone Feb 4, 2023
@schalkms
schalkms merged commit 22d491d into detekt:main Feb 4, 2023
@3flex
3flex deleted the 5645-fix branch February 4, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report or fail build when kotlin-compiler-embeddable version is overridden detekt 1.22.0 no longer works with kotlin <1.7

3 participants