Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to SnakeYAML Engine #5751

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Conversation

asomov
Copy link
Contributor

@asomov asomov commented Feb 3, 2023

Migrate to SnakeYAML Engine to eliminate the CVE issue

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detekt found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #5751 (e426325) into main (369d673) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e426325 differs from pull request most recent head 85a9af4. Consider uploading reports for the commit 85a9af4 to get more accurate results

@@            Coverage Diff            @@
##               main    #5751   +/-   ##
=========================================
  Coverage     84.48%   84.49%           
  Complexity     3734     3734           
=========================================
  Files           544      544           
  Lines         12752    12759    +7     
  Branches       2232     2232           
=========================================
+ Hits          10774    10781    +7     
  Misses          864      864           
  Partials       1114     1114           
Impacted Files Coverage Δ
...gitlab/arturbosch/detekt/core/config/YamlConfig.kt 88.57% <100.00%> (+2.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!
To merge this, a few code scanning issues need to be resolved. Afterwards, I'd say LGTM.

@asomov
Copy link
Contributor Author

asomov commented Feb 6, 2023

@schalkms I think all the format suggestions were applied

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@schalkms schalkms added this to the 1.23.0 milestone Feb 6, 2023
@3flex 3flex merged commit f0460bc into detekt:main Feb 9, 2023
@asomov asomov deleted the migrate-to-snakeyaml-engine branch February 10, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build core dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants