Use stdlib functions for file & path operations

[3flex]

I set out to remove these imports and use replacements from stdlib:

• java.io.File
• java.nio.file.Files
• java.nio.file.Paths

I was mostly successful, held back by the detekt-gradle-plugin being on API version 1.4, and a couple of stdlib functions which still require an opt in. I chose not to use the opt in functions until they're stable, hopefully in Kotlin 1.9 if not before.

I recommend reviewing by individual commit as I've broken up the changes into logical chunks.

[codecov]

Codecov Report

Merging #5754 (91597c9) into main (728de81) will decrease coverage by 0.02%.
The diff coverage is 58.02%.

@@             Coverage Diff              @@
##               main    #5754      +/-   ##
============================================
- Coverage     84.60%   84.59%   -0.02%     
  Complexity     3790     3790              
============================================
  Files           547      547              
  Lines         12917    12909       -8     
  Branches       2262     2262              
============================================
- Hits          10929    10920       -9     
- Misses          861      862       +1     
  Partials       1127     1127              

Impacted Files	Coverage Δ
.../detekt/compiler/plugin/DetektAnalysisExtension.kt	0.00% <0.00%> (ø)
...tekt/compiler/plugin/DetektCommandLineProcessor.kt	0.00% <0.00%> (ø)
...t/compiler/plugin/DetektCompilerPluginRegistrar.kt	0.00% <0.00%> (ø)
...in/kotlin/io/gitlab/arturbosch/detekt/core/Junk.kt	100.00% <ø> (ø)
...io/gitlab/arturbosch/detekt/core/KtFileModifier.kt	0.00% <0.00%> (ø)
.../arturbosch/detekt/core/baseline/BaselineFacade.kt	86.66% <0.00%> (ø)
...arturbosch/detekt/core/baseline/DefaultBaseline.kt	75.00% <0.00%> (ø)
...rturbosch/detekt/core/settings/ClassloaderAware.kt	63.63% <0.00%> (ø)
...b/arturbosch/detekt/core/tooling/AnalysisFacade.kt	62.85% <0.00%> (ø)
...tlin/io/gitlab/arturbosch/detekt/generator/Main.kt	38.46% <0.00%> (ø)
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[Goooler]

And these ones

detekt/detekt-cli/src/main/kotlin/io/gitlab/arturbosch/detekt/cli/ArgumentConverters.kt

Lines 15 to 18 in 80bae4b

	val config = File(value).toPath()
	if (Files.notExists(config)) {
	throw ParameterException("Provided path '$value' does not exist!")
	}

detekt/detekt-cli/src/main/kotlin/io/gitlab/arturbosch/detekt/cli/ArgumentConverters.kt

Lines 23 to 27 in 80bae4b

	class PathConverter : IStringConverter<Path> {
	override fun convert(value: String): Path {
	return Paths.get(value)
	}
	}

[3flex]

@Goooler they're already covered?

https://github.com/detekt/detekt/pull/5754/files#diff-1d7a1cd6085118b76e5689c6c2bdd234c831a4bc566dfbb946975b90c1b2585e

[Goooler]

You are right, just see it.

[BraisGabin]

<3

[BraisGabin]

Great work!