Skip to content

Replace java.util.Stack with Kotlin's ArrayDeque implementation#5760

Merged
3flex merged 1 commit into
detekt:mainfrom
3flex:drop-stack
Feb 5, 2023
Merged

Replace java.util.Stack with Kotlin's ArrayDeque implementation#5760
3flex merged 1 commit into
detekt:mainfrom
3flex:drop-stack

Conversation

@3flex

@3flex 3flex commented Feb 5, 2023

Copy link
Copy Markdown
Member

From java.util.Stack Javadoc:

A more complete and consistent set of LIFO stack operations is provided by the Deque interface and its implementations, which should be used in preference to this class.

I've used Kotlin's implementation instead of a Java implementation.

@codecov

codecov Bot commented Feb 5, 2023

Copy link
Copy Markdown

Codecov Report

Merging #5760 (52baad9) into main (488d0b8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #5760   +/-   ##
=========================================
  Coverage     84.52%   84.52%           
  Complexity     3731     3731           
=========================================
  Files           544      544           
  Lines         12759    12759           
  Branches       2232     2232           
=========================================
  Hits          10785    10785           
  Misses          864      864           
  Partials       1110     1110           
Impacted Files Coverage Δ
...h/detekt/core/baseline/IndentingXMLStreamWriter.kt 56.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@schalkms schalkms added this to the 1.23.0 milestone Feb 5, 2023
@3flex
3flex merged commit d3c97f6 into detekt:main Feb 5, 2023
@3flex
3flex deleted the drop-stack branch February 5, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants