-
-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude the KMP test folders for android #5797
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5797 +/- ##
============================================
+ Coverage 84.59% 84.60% +0.01%
- Complexity 3788 3790 +2
============================================
Files 547 547
Lines 12875 12917 +42
Branches 2250 2262 +12
============================================
+ Hits 10891 10929 +38
- Misses 860 861 +1
- Partials 1124 1127 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
...tor/src/main/kotlin/io/gitlab/arturbosch/detekt/generator/printer/defaultconfig/Exclusion.kt
Show resolved
Hide resolved
...tor/src/main/kotlin/io/gitlab/arturbosch/detekt/generator/printer/defaultconfig/Exclusion.kt
Fixed
Show fixed
Hide fixed
...tor/src/main/kotlin/io/gitlab/arturbosch/detekt/generator/printer/defaultconfig/Exclusion.kt
Outdated
Show resolved
Hide resolved
...tor/src/main/kotlin/io/gitlab/arturbosch/detekt/generator/printer/defaultconfig/Exclusion.kt
Outdated
Show resolved
Hide resolved
...tor/src/main/kotlin/io/gitlab/arturbosch/detekt/generator/printer/defaultconfig/Exclusion.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, just a few nits. I would definitely resolve the ordering problem rather than working around it with a get()
.
...tor/src/main/kotlin/io/gitlab/arturbosch/detekt/generator/printer/defaultconfig/Exclusion.kt
Show resolved
Hide resolved
...tor/src/main/kotlin/io/gitlab/arturbosch/detekt/generator/printer/defaultconfig/Exclusion.kt
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks clean :)
Funny about the space in the separator, nice catch.
Fix #5727
The old tests were
androidTest
andandroidAndroidTest
(we didn't support this one) and the new ones areandroidUnitTest
andandroidInstrumentedTest
. It's better to just excludeandroid*Test
.