Exclude the KMP test folders for android#5797
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5797 +/- ##
============================================
+ Coverage 84.59% 84.60% +0.01%
- Complexity 3788 3790 +2
============================================
Files 547 547
Lines 12875 12917 +42
Branches 2250 2262 +12
============================================
+ Hits 10891 10929 +38
- Misses 860 861 +1
- Partials 1124 1127 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
TWiStErRob
approved these changes
Feb 21, 2023
BraisGabin
commented
Feb 21, 2023
TWiStErRob
reviewed
Feb 21, 2023
TWiStErRob
reviewed
Feb 21, 2023
TWiStErRob
approved these changes
Feb 21, 2023
TWiStErRob
left a comment
Member
There was a problem hiding this comment.
Looks ok, just a few nits. I would definitely resolve the ordering problem rather than working around it with a get().
TWiStErRob
approved these changes
Feb 21, 2023
TWiStErRob
left a comment
Member
There was a problem hiding this comment.
Nice, looks clean :)
Funny about the space in the separator, nice catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5727
The old tests were
androidTestandandroidAndroidTest(we didn't support this one) and the new ones areandroidUnitTestandandroidInstrumentedTest. It's better to just excludeandroid*Test.