Skip to content

Exclude the KMP test folders for android#5797

Merged
BraisGabin merged 1 commit into
mainfrom
fix-5727
Feb 21, 2023
Merged

Exclude the KMP test folders for android#5797
BraisGabin merged 1 commit into
mainfrom
fix-5727

Conversation

@BraisGabin

Copy link
Copy Markdown
Member

Fix #5727

The old tests were androidTest and androidAndroidTest (we didn't support this one) and the new ones are androidUnitTest and androidInstrumentedTest. It's better to just exclude android*Test.

@codecov

codecov Bot commented Feb 21, 2023

Copy link
Copy Markdown

Codecov Report

Merging #5797 (edc4497) into main (b2299a9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #5797      +/-   ##
============================================
+ Coverage     84.59%   84.60%   +0.01%     
- Complexity     3788     3790       +2     
============================================
  Files           547      547              
  Lines         12875    12917      +42     
  Branches       2250     2262      +12     
============================================
+ Hits          10891    10929      +38     
- Misses          860      861       +1     
- Partials       1124     1127       +3     
Impacted Files Coverage Δ
...etekt/generator/printer/defaultconfig/Exclusion.kt 97.22% <100.00%> (+0.92%) ⬆️
...turbosch/detekt/rules/style/UnusedPrivateMember.kt 89.90% <0.00%> (-2.32%) ⬇️
...bosch/detekt/rules/style/UnnecessaryParentheses.kt 85.93% <0.00%> (+3.93%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TWiStErRob TWiStErRob left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, just a few nits. I would definitely resolve the ordering problem rather than working around it with a get().

@TWiStErRob TWiStErRob left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks clean :)

Funny about the space in the separator, nice catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exclude new Kotlin Test directories in default config

3 participants