-
-
Notifications
You must be signed in to change notification settings - Fork 794
FunctionMatcher support for fully qualified function names #5812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FunctionMatcher support for fully qualified function names #5812
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5812 +/- ##
============================================
+ Coverage 84.48% 84.56% +0.07%
- Complexity 3743 3785 +42
============================================
Files 546 546
Lines 12788 12936 +148
Branches 2230 2275 +45
============================================
+ Hits 10804 10939 +135
+ Misses 869 863 -6
- Partials 1115 1134 +19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This looks good! You didn't relate this with the issue because right now it doesn't fix that issue, right? |
I want to go through tests one more time, I have a suspension that they dont check behavior correctly |
Now it should be correct. Previously most tests assumed that function is in the root package. So if we remove name check inside matcher tests would still pass. Not a case anymore |
Fixes #5767 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one :) Thanks!
detekt-tooling/src/test/kotlin/io/github/detekt/tooling/api/FunctionMatcherSpec.kt
Outdated
Show resolved
Hide resolved
detekt-tooling/src/test/kotlin/io/github/detekt/tooling/api/FunctionMatcherSpec.kt
Outdated
Show resolved
Hide resolved
…nctionMatcherSpec.kt
…nctionMatcherSpec.kt
Now matcher will check both simple name e.g.
foo
and fully qualified one e.g.com.github.detekt.FooBar.foo
.Fixes #5767