FunctionMatcher support for fully qualified function names - #5812
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5812 +/- ##
============================================
+ Coverage 84.48% 84.56% +0.07%
- Complexity 3743 3785 +42
============================================
Files 546 546
Lines 12788 12936 +148
Branches 2230 2275 +45
============================================
+ Hits 10804 10939 +135
+ Misses 869 863 -6
- Partials 1115 1134 +19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This looks good! You didn't relate this with the issue because right now it doesn't fix that issue, right? |
I want to go through tests one more time, I have a suspension that they dont check behavior correctly |
Now it should be correct. Previously most tests assumed that function is in the root package. So if we remove name check inside matcher tests would still pass. Not a case anymore |
|
Fixes #5767 |
…nctionMatcherSpec.kt
…nctionMatcherSpec.kt
Now matcher will check both simple name e.g.
fooand fully qualified one e.g.com.github.detekt.FooBar.foo.Fixes #5767