Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate MultilineRawStringIndentation on detekt #5819

Merged
merged 4 commits into from
Feb 24, 2023

Conversation

BraisGabin
Copy link
Member

Improve the indentation of our tests

@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Feb 24, 2023
@BraisGabin BraisGabin force-pushed the activate-MultilineRawStringIndentation branch from 024c1ca to c21fa34 Compare February 24, 2023 09:37
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #5819 (193b689) into main (ce343fe) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #5819      +/-   ##
============================================
- Coverage     84.60%   84.59%   -0.01%     
  Complexity     3790     3790              
============================================
  Files           546      546              
  Lines         12918    12918              
  Branches       2268     2268              
============================================
- Hits          10929    10928       -1     
  Misses          861      861              
- Partials       1128     1129       +1     
Impacted Files Coverage Δ
...t/generator/printer/defaultconfig/ConfigPrinter.kt 100.00% <ø> (ø)
...turbosch/detekt/rules/style/UnusedPrivateMember.kt 88.99% <0.00%> (-0.92%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

 * extract some more code vals
 * remove trailing tabs
 * add some spaces after commas
 * add some more private vals
Copy link
Member

@TWiStErRob TWiStErRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most boring PR ever. (that's a big compliment 😜)

fun <V> two() : Int
where V : Number =
2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a rule for leading/trailing empty lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean for code or inside raw strings? For code I think that ktlint does that. On raw string there's nothing as far as I know.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for raw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants