Enable test retry for all our modules - #5825
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5825 +/- ##
=========================================
Coverage 84.59% 84.59%
Complexity 3790 3790
=========================================
Files 546 546
Lines 12918 12918
Branches 2268 2268
=========================================
Hits 10928 10928
Misses 861 861
Partials 1129 1129 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cortinico
reviewed
Feb 26, 2023
| subprojects { | ||
| tasks.withType<Test>().configureEach { | ||
| retry { | ||
| @Suppress("MagicNumber") |
Member
There was a problem hiding this comment.
Perhaps we can really extract those as top level constants?
Member
Author
There was a problem hiding this comment.
To me these are false positives. maxRetries.set(3) is clear what 3 does. We don't need a constant to make it easier to understand.
cortinico
approved these changes
Feb 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a point we talked with the Gradle folks. It improves the predictive tests.
Documentation: https://docs.gradle.com/enterprise/predictive-test-selection/#flaky_test_retry