-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable PTS from local and enable it for PRs #5826
Conversation
@clayburn or @runningcode could you take a look to this one? |
Codecov Report
@@ Coverage Diff @@
## main #5826 +/- ##
============================================
- Coverage 84.57% 84.56% -0.01%
+ Complexity 3787 3785 -2
============================================
Files 546 546
Lines 12936 12935 -1
Branches 2273 2273
============================================
- Hits 10940 10939 -1
Misses 863 863
Partials 1133 1133
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm only mildly familiar with the GitHub Actions part. If github.event_name == 'push' && github.ref == 'refs/heads/main'
executes on main after pull requests are merged to main, then this looks good to me! The intent of this looks correct.
1542fc0
to
01eba25
Compare
01eba25
to
c359c38
Compare
ddaf839
to
384dc06
Compare
384dc06
to
7b2fd3d
Compare
Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks minimally correct to me :)
I would like to have more eyes on this to ensure that we are ok with the change that this implies. The code is really simple now but I want to be sure that we agree with this. Don't run ALL the tests on each PR is a big deal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to have more eyes on this
+1 on my end for this
The github yaml configuration make this a bit ugly.
This was discussed with the gradle folks on how to improve the usage of PTS.
PTS on local doesn't provide us too much benefits because it breaks the incremental compilariont (
UP-TO-DATE
check).The idea is that we make our PR checks faster now that we have a trained PTS but we run all our tests once it's merged to
main
to ensure that nothing was broken.