Skip to content

Exclude super call when generating guard clauses - #5835

Merged
schalkms merged 1 commit into
detekt:mainfrom
atulgpt:fixes-5680
Feb 26, 2023
Merged

Exclude super call when generating guard clauses#5835
schalkms merged 1 commit into
detekt:mainfrom
atulgpt:fixes-5680

Conversation

@atulgpt

@atulgpt atulgpt commented Feb 25, 2023

Copy link
Copy Markdown
Contributor

Fixes #5680

@codecov

codecov Bot commented Feb 25, 2023

Copy link
Copy Markdown

Codecov Report

Merging #5835 (0e50d27) into main (2e703f0) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff            @@
##               main    #5835   +/-   ##
=========================================
  Coverage     84.59%   84.59%           
  Complexity     3776     3776           
=========================================
  Files           546      546           
  Lines         12916    12917    +1     
  Branches       2268     2269    +1     
=========================================
+ Hits          10926    10927    +1     
  Misses          861      861           
  Partials       1129     1129           
Impacted Files Coverage Δ
.../io/gitlab/arturbosch/detekt/rules/GuardClauses.kt 13.33% <50.00%> (+6.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cortinico

Copy link
Copy Markdown
Member

Great stuff 👍

@cortinico cortinico added this to the 1.23.0 milestone Feb 26, 2023
@schalkms
schalkms merged commit 455096e into detekt:main Feb 26, 2023
@atulgpt
atulgpt deleted the fixes-5680 branch February 26, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

excludeGuardClauses in ReturnCount should ignore first super call

3 participants