Skip to content

MagicNumber - Make ignoreNamedArgument catch more complex expression#5837

Merged
schalkms merged 2 commits into
detekt:mainfrom
cortinico:nc/5758
Feb 26, 2023
Merged

MagicNumber - Make ignoreNamedArgument catch more complex expression#5837
schalkms merged 2 commits into
detekt:mainfrom
cortinico:nc/5758

Conversation

@cortinico

Copy link
Copy Markdown
Member

Fixes #5758

@codecov

codecov Bot commented Feb 26, 2023

Copy link
Copy Markdown

Codecov Report

Merging #5837 (f7ce618) into main (d067a13) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #5837      +/-   ##
============================================
- Coverage     84.59%   84.59%   -0.01%     
+ Complexity     3776     3774       -2     
============================================
  Files           546      546              
  Lines         12916    12914       -2     
  Branches       2268     2267       -1     
============================================
- Hits          10926    10924       -2     
  Misses          861      861              
  Partials       1129     1129              
Impacted Files Coverage Δ
...itlab/arturbosch/detekt/rules/style/MagicNumber.kt 91.01% <100.00%> (-0.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@schalkms

Copy link
Copy Markdown
Member

Way easier to understand now 👍

@schalkms
schalkms merged commit 3a6fc46 into detekt:main Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MagicNumber lint fix

3 participants