New Rule: BracesOnWhenStatements with configurable parameters#5838
Merged
Conversation
VitalyVPinchuk
changed the title
BracesOnWhenStatements with configurable parameters
Codecov Report
@@ Coverage Diff @@
## main #5838 +/- ##
============================================
+ Coverage 84.59% 84.68% +0.09%
- Complexity 3776 3859 +83
============================================
Files 546 550 +4
Lines 12916 13109 +193
Branches 2268 2313 +45
============================================
+ Hits 10926 11102 +176
- Misses 861 868 +7
- Partials 1129 1139 +10
... and 59 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
BraisGabin
reviewed
Feb 28, 2023
BraisGabin
approved these changes
Mar 3, 2023
TWiStErRob
requested changes
Mar 7, 2023
TWiStErRob
left a comment
TWiStErRob
left a comment
Member
There was a problem hiding this comment.
Nice one, a few changes are needed to make sense of consistent/multi-statement. But the majority is good! Thank you!
…/rules/style/BracesOnWhenStatements.kt Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>
…/rules/style/BracesOnWhenStatements.kt Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>
…/rules/style/BracesOnWhenStatements.kt Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>
…/rules/style/BracesOnWhenStatements.kt Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>
VitalyVPinchuk
force-pushed
the
braces_when
branch
from
2e41d56 to
5872284
Compare
VitalyVPinchuk
force-pushed
the
braces_when
branch
from
5872284 to
3497d3d
Compare
VitalyVPinchuk
force-pushed
the
braces_when
branch
from
3497d3d to
99ade13
Compare
Contributor
Author
|
Also, I can't engage this rule in |
Member
I don't understand the your statment. Can you elavorate? |
Contributor
Author
I mean if I turn on this rule, detekt task fails. No matter what parameters I use in the rule: consistent, necessary, etc. We have to fix codebase a bit |
Member
|
Oh, sure. No problem about that. We can enable it later in other pr with the proper fixes. |
TWiStErRob
reviewed
Mar 17, 2023
TWiStErRob
reviewed
Apr 5, 2023
Member
There was a problem hiding this comment.
Sorry for the delay, move was longer than expected. This looks good now, just some final touches / simplifications. Happy to help finishing up, find me on Slack. Please look through all the unresolved conversations on the PR, there might be some hiding behind expanders.
VitalyVPinchuk
force-pushed
the
braces_when
branch
from
bbc41bf to
457c337
Compare
TWiStErRob
reviewed
Apr 13, 2023
TWiStErRob
reviewed
Apr 13, 2023
TWiStErRob
approved these changes
Apr 13, 2023
…/rules/style/BracesOnWhenStatements.kt Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #5133
Similar to #5700