Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary @Suppress("ReturnCount") #5841

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Remove unnecessary @Suppress("ReturnCount") #5841

merged 1 commit into from
Feb 27, 2023

Conversation

BraisGabin
Copy link
Member

This is doable thanks to #5835

@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Merging #5841 (dd25073) into main (3a6fc46) will decrease coverage by 0.02%.
The diff coverage is 42.85%.

@@             Coverage Diff              @@
##               main    #5841      +/-   ##
============================================
- Coverage     84.56%   84.55%   -0.02%     
- Complexity     3785     3786       +1     
============================================
  Files           546      546              
  Lines         12935    12932       -3     
  Branches       2273     2272       -1     
============================================
- Hits          10939    10935       -4     
  Misses          863      863              
- Partials       1133     1134       +1     
Impacted Files Coverage Δ
...turbosch/detekt/rules/complexity/NamedArguments.kt 86.20% <ø> (ø)
...sch/detekt/rules/coroutines/SleepInsteadOfDelay.kt 73.46% <0.00%> (-0.54%) ⬇️
...ab/arturbosch/detekt/rules/bugs/ExitOutsideMain.kt 76.92% <ø> (ø)
...arturbosch/detekt/rules/bugs/IgnoredReturnValue.kt 89.09% <ø> (ø)
...rbosch/detekt/rules/bugs/ImplicitUnitReturnType.kt 93.33% <ø> (ø)
...turbosch/detekt/rules/bugs/NullableToStringCall.kt 89.18% <ø> (ø)
...bosch/detekt/rules/bugs/UnnecessaryNotNullCheck.kt 88.46% <ø> (ø)
...rturbosch/detekt/rules/bugs/UnnecessarySafeCall.kt 90.90% <ø> (ø)
...urbosch/detekt/rules/bugs/UnreachableCatchBlock.kt 73.68% <ø> (ø)
...rbosch/detekt/rules/performance/CouldBeSequence.kt 87.50% <ø> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@3flex
Copy link
Member

3flex commented Feb 26, 2023

Nice!

@BraisGabin BraisGabin added this to the 1.23.0 milestone Feb 26, 2023
@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Feb 26, 2023
@3flex 3flex merged commit 0e9ea12 into main Feb 27, 2023
@3flex 3flex deleted the followup-5835 branch February 27, 2023 09:26
@cortinico
Copy link
Member

Love this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants