Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort deprecation properties #5845

Merged
merged 3 commits into from
Mar 1, 2023
Merged

Sort deprecation properties #5845

merged 3 commits into from
Mar 1, 2023

Conversation

BraisGabin
Copy link
Member

@BraisGabin BraisGabin commented Feb 27, 2023

#5844 shows that the order of the deprecations.properties depend on the order of the inputs. That should not happen. This PR fixes that.

@BraisGabin BraisGabin added this to the 1.23.0 milestone Feb 27, 2023
@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #5845 (ab5a3f4) into main (b8c0aaa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #5845   +/-   ##
=========================================
  Coverage     84.56%   84.56%           
+ Complexity     3785     3784    -1     
=========================================
  Files           546      546           
  Lines         12936    12942    +6     
  Branches       2275     2274    -1     
=========================================
+ Hits          10939    10945    +6     
  Misses          863      863           
  Partials       1134     1134           
Impacted Files Coverage Δ
...ekt/generator/collection/ConfigurationCollector.kt 62.72% <ø> (ø)
...lab/arturbosch/detekt/generator/collection/Rule.kt 100.00% <100.00%> (ø)
...urbosch/detekt/generator/collection/RuleVisitor.kt 89.89% <100.00%> (ø)
...osch/detekt/generator/printer/DeprecatedPrinter.kt 100.00% <100.00%> (ø)
...arturbosch/detekt/generator/printer/RulePrinter.kt 96.66% <100.00%> (ø)
...ator/printer/defaultconfig/RuleSetConfigPrinter.kt 92.30% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@BraisGabin BraisGabin merged commit ca9de8f into main Mar 1, 2023
@BraisGabin BraisGabin deleted the sort-deprecation-properties branch March 1, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants