Skip to content

Sort deprecation properties#5845

Merged
BraisGabin merged 3 commits intomainfrom
sort-deprecation-properties
Mar 1, 2023
Merged

Sort deprecation properties#5845
BraisGabin merged 3 commits intomainfrom
sort-deprecation-properties

Conversation

@BraisGabin
Copy link
Copy Markdown
Member

@BraisGabin BraisGabin commented Feb 27, 2023

#5844 shows that the order of the deprecations.properties depend on the order of the inputs. That should not happen. This PR fixes that.

@BraisGabin BraisGabin added this to the 1.23.0 milestone Feb 27, 2023
@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Feb 27, 2023
@BraisGabin BraisGabin force-pushed the sort-deprecation-properties branch from b4ad6f8 to ab5a3f4 Compare February 27, 2023 01:07
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2023

Codecov Report

Merging #5845 (ab5a3f4) into main (b8c0aaa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #5845   +/-   ##
=========================================
  Coverage     84.56%   84.56%           
+ Complexity     3785     3784    -1     
=========================================
  Files           546      546           
  Lines         12936    12942    +6     
  Branches       2275     2274    -1     
=========================================
+ Hits          10939    10945    +6     
  Misses          863      863           
  Partials       1134     1134           
Impacted Files Coverage Δ
...ekt/generator/collection/ConfigurationCollector.kt 62.72% <ø> (ø)
...lab/arturbosch/detekt/generator/collection/Rule.kt 100.00% <100.00%> (ø)
...urbosch/detekt/generator/collection/RuleVisitor.kt 89.89% <100.00%> (ø)
...osch/detekt/generator/printer/DeprecatedPrinter.kt 100.00% <100.00%> (ø)
...arturbosch/detekt/generator/printer/RulePrinter.kt 96.66% <100.00%> (ø)
...ator/printer/defaultconfig/RuleSetConfigPrinter.kt 92.30% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@BraisGabin BraisGabin merged commit ca9de8f into main Mar 1, 2023
@BraisGabin BraisGabin deleted the sort-deprecation-properties branch March 1, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants