Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency between check and jacocoMergedReport #5846

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

BraisGabin
Copy link
Member

jacocoMergedReport is in the critical path of my builds:
https://ge.detekt.dev/s/24zl4n3tj746e/timeline?details=j2hxxhlnrx3wg&show-only-critical-path
https://ge.detekt.dev/s/ok5dejkm7eo34/timeline?details=j2hxxhlnrx3wg&show-only-critical-path

But its output is not relevant. The only place where it is relevant is in the workflow codecoverage.yaml. But there we don't execute it using check we execute it using its name.

@github-actions github-actions bot added the build label Feb 27, 2023
@BraisGabin BraisGabin added housekeeping Marker for housekeeping tasks and refactorings and removed build labels Feb 27, 2023
@BraisGabin BraisGabin added this to the 1.23.0 milestone Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #5846 (e1b10bd) into main (b8c0aaa) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #5846   +/-   ##
=========================================
  Coverage     84.56%   84.56%           
  Complexity     3785     3785           
=========================================
  Files           546      546           
  Lines         12936    12936           
  Branches       2275     2275           
=========================================
  Hits          10939    10939           
  Misses          863      863           
  Partials       1134     1134           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@3flex
Copy link
Member

3flex commented Feb 27, 2023

its output is not relevant

Just FYI there's an aggregated HTML report generated by the report aggregation task, so it's not only used by Codecov.

But reading the definition of check from Gradle docs it says that verification tasks should be attached, but this isn't a verification task as such, so it makes sense to drop it.

@3flex 3flex merged commit fabc8aa into main Feb 27, 2023
@3flex 3flex deleted the improve-compilation branch February 27, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants