MatchingDeclarationName. KtFilesSpec also remove .common.kt suffix from kotlin files#5851
Merged
BraisGabin merged 4 commits intoFeb 28, 2023
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5851 +/- ##
============================================
+ Coverage 84.48% 84.58% +0.09%
- Complexity 3743 3785 +42
============================================
Files 546 546
Lines 12788 12941 +153
Branches 2230 2276 +46
============================================
+ Hits 10804 10946 +142
+ Misses 869 862 -7
- Partials 1115 1133 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
BraisGabin
reviewed
Feb 27, 2023
BraisGabin
left a comment
BraisGabin
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks! I just left some minor things.
|
|
||
| /** | ||
| * Removes kotlin specific file name suffixes, e.g. .kt. | ||
| * Note, will note remove other possible/knowb file suffixes like .java |
Member
There was a problem hiding this comment.
Suggested change
| * Note, will note remove other possible/knowb file suffixes like .java | |
| * Note, will not remove other possible/knowb file suffixes like .java |
Contributor
Author
There was a problem hiding this comment.
fixed, also knowb -> known
| const val KOTLIN_SCRIPT_SUFFIX = ".kts" | ||
| const val KOTLIN_KMP_COMMON_SUFFIX = ".common.kt" | ||
|
|
||
| val KOTLIN_FILE_SUFFIXES = arrayOf( |
Member
There was a problem hiding this comment.
Suggested change
| val KOTLIN_FILE_SUFFIXES = arrayOf( | |
| private val KOTLIN_FILE_SUFFIXES = arrayOf( |
|
|
||
| const val KOTLIN_SUFFIX = ".kt" | ||
| const val KOTLIN_SCRIPT_SUFFIX = ".kts" | ||
| const val KOTLIN_KMP_COMMON_SUFFIX = ".common.kt" |
Member
There was a problem hiding this comment.
Suggested change
| const val KOTLIN_KMP_COMMON_SUFFIX = ".common.kt" | |
| private const val KOTLIN_KMP_COMMON_SUFFIX = ".common.kt" |
cortinico
approved these changes
Feb 27, 2023
BraisGabin
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No changes for rule itself, but MatchingDeclarationName now will threat
.common.ktsuffix as known kotlin file part.