Tweak GHA configs a bit #5852
Tweak GHA configs a bit #5852
Conversation
# Conflicts: # .github/workflows/pre-merge.yaml
| @@ -38,6 +36,7 @@ jobs: | |||
| - name: Build Detekt Documentation | |||
| uses: gradle/gradle-build-action@6095a76664413da4c8c134ee32e8a8ae900f0f1f # v2 | |||
| with: | |||
| gradle-home-cache-cleanup: true | |||
There was a problem hiding this comment.
I'm not sure why this is not their default value.
If in one action we execute just help and in other build. We'll the help action remove a lot of files that are used by the build one? My point is, do we know if this is always a net win? Does it have side effects?
I assume that the desired side effect is that if we would like to roll back a gradle upgrade we would need to download some things again. But that is completely reasonable and unlikely to happen. But are there others?
My fear is that this would create far too many misses.
There was a problem hiding this comment.
I enable this flag on our internal repos, cause the cache sizes grow up to about 2~3 GB, spend too much time on restoring caches. Either way, I can revert these lines if you want.
There was a problem hiding this comment.
My fear is that this would create far too many misses.
Let's merge it for now, and report back to Gradle if this degrading the GE experience (it's their custom GH Action afterall)
| @@ -38,6 +36,7 @@ jobs: | |||
| - name: Build Detekt Documentation | |||
| uses: gradle/gradle-build-action@6095a76664413da4c8c134ee32e8a8ae900f0f1f # v2 | |||
| with: | |||
| gradle-home-cache-cleanup: true | |||
There was a problem hiding this comment.
My fear is that this would create far too many misses.
Let's merge it for now, and report back to Gradle if this degrading the GE experience (it's their custom GH Action afterall)
# Conflicts: # .github/workflows/detekt-with-type-resolution.yaml
Codecov Report
@@ Coverage Diff @@
## main #5852 +/- ##
=========================================
Coverage 84.57% 84.57%
Complexity 3785 3785
=========================================
Files 546 546
Lines 12944 12944
Branches 2274 2274
=========================================
Hits 10948 10948
Misses 862 862
Partials 1134 1134 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thanks for the cleanup :) |
https://github.com/gradle/gradle-build-action/blob/main/README.md#removing-unused-files-from-gradle-user-home-before-saving-to-cache
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch